Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable alarms for current day #17

Closed
3 tasks done
mithomas opened this issue Oct 14, 2023 · 4 comments · Fixed by #18
Closed
3 tasks done

Add option to disable alarms for current day #17

mithomas opened this issue Oct 14, 2023 · 4 comments · Fixed by #18
Labels
enhancement New feature or request

Comments

@mithomas
Copy link

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

Nintendo's parental control app has a button to disable alarms for the current day - this one is notably absent from the integration.

Describe the solution you'd like

I'd like a new switch which controls the "Disable alarms for the current day" functionality.

I suspect that this might be a setting in the parental_control_settings dict, but I have yet to see the actual JSON for such a communication so II honestly don't know. I did not yet invest the time to reverse-engineer the API in this regard; if you do that structure, I'd be happy to implement this myself and raise a PR. (If you don't I might too at some point, it just will take longer :-).)

Describe alternatives you've considered

n/a

Additional context

Thanks for the effort you put in here so far - great work!

@pantherale0 pantherale0 added the enhancement New feature or request label Oct 14, 2023
@pantherale0
Copy link
Owner

Nice idea, I'll take a look today or tomorrow 👍

@pantherale0
Copy link
Owner

Ok, so the functionality for performing the action is already in the pynintendoparental module, just couldn't figure out where the state actually exists in the API itself hence why it was never quite completed. Just bumped the version on the module though as I've now figured out that the current state doesn't actually come from the parental control settings, but instead comes from the device properties itself.

Should be fairly simple to implement a switch now after the changes made in #15. There are a couple of other fixes coming in #16 but I'll get a switch added after I've finished the reauth flows

pantherale0 added a commit that referenced this issue Oct 15, 2023
fixes Add option to disable alarms for current day #17
update readme
@pantherale0 pantherale0 linked a pull request Oct 15, 2023 that will close this issue
pantherale0 added a commit that referenced this issue Oct 15, 2023
* (switch) implement switch to disable alarms
fixes Add option to disable alarms for current day #17
update readme

* (sys) bump version for beta 0
@pantherale0
Copy link
Owner

will be implemented in 0.1.4

@mithomas
Copy link
Author

Works great in 0.1.4b0 - many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants