Fix regex for gitlab tokens. #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CdrMarks
reviewed
Jan 28, 2022
.circleci/set-up-globals.sh
Outdated
| rm /usr/local/bin/terminus | ||
| ln -s /opt/terminus/bin/t3 /usr/local/bin/terminus | ||
| mkdir ~/terminus && cd ~/terminus | ||
| curl -L https://github.com/pantheon-systems/terminus/releases/download/`curl --silent "https://api.github.com/repos/pantheon-systems/terminus/releases/latest" | perl -nle'print $& while m#"tag_name": "\K[^"]*#g'`/terminus.phar --output terminus |
There was a problem hiding this comment.
Is it correct that there shouldn't be a space after download/?
There was a problem hiding this comment.
I guess so. For readability, it seems that the nested curl statement could be on a line before this and then included in the download URL as a varible.
There was a problem hiding this comment.
I pushed this to address that: 1cfa0b7
CdrMarks
approved these changes
Jan 28, 2022
greg-1-anderson
approved these changes
Jan 28, 2022
…s-plugin into gitlab-token
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously 20 characters, now it's 26 characters. I'm opening support for both in case there are old gitlab installations still on 20 characters (not even sure if this is possible though)