Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out this curl command into separate lines #7031

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

CdrMarks
Copy link
Contributor

@CdrMarks CdrMarks commented Jan 28, 2022

Summary

Install - Break out a complex curl command, with a curl command nested within, into separate lines.

I saw this in pantheon-systems/terminus-build-tools-plugin#427 and felt it would be good to update it here too.

Dependencies and Timing

Release:

  • When ready

Post Launch

Do not remove - To be completed by the docs team upon merge:

  • Redirect /docs/old-path/ => /docs/new-path/ (if applicable)
  • Include/exclude pages ^ respectively within docs search service provider (if applicable)
  • For Heroes - add a props post to the discussion board.
  • Remove from the project board

@CdrMarks CdrMarks added Source: Pantheor Contribution from within Pantheon, unspecified team Topic: Terminus labels Jan 28, 2022
@pantheondocs
Copy link

Lighthouse Audit Results:

Description Live pr-7031 Difference
Performance Score 49 50 1
Best Practice Score 79 79 0
SEO Score 96 96 0
Accessibility Score 96 96 0

Lighthouse Audit Reports:

Preview Environment

@whitneymeredith whitneymeredith self-assigned this Feb 1, 2022
@whitneymeredith whitneymeredith self-requested a review February 1, 2022 17:42
Copy link
Contributor

@whitneymeredith whitneymeredith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whitneymeredith whitneymeredith merged commit 7ce9e3f into main Feb 1, 2022
@pantheondocs pantheondocs deleted the terminis-install-curl branch February 1, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source: Pantheor Contribution from within Pantheon, unspecified team Topic: Terminus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants