Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix SparseFrameAccessor.to_dense return type #59967

Merged
merged 2 commits into from
Oct 4, 2024
Merged

BUG: Fix SparseFrameAccessor.to_dense return type #59967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b2363
BUG: Fix SparseFrameAccessor.to_dense return type
janezd Oct 4, 2024
12a5c7b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,7 @@ Sparse
^^^^^^
- Bug in :class:`SparseDtype` for equal comparison with na fill value. (:issue:`54770`)
- Bug in :meth:`DataFrame.sparse.from_spmatrix` which hard coded an invalid ``fill_value`` for certain subtypes. (:issue:`59063`)
- Bug in :meth:`DataFrame.sparse.to_dense` which ignored subclassing and always returned an instance of :class:`DataFrame` (:issue:`59913`)

ExtensionArray
^^^^^^^^^^^^^^
Expand Down
5 changes: 2 additions & 3 deletions pandas/core/arrays/sparse/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,10 +369,9 @@ def to_dense(self) -> DataFrame:
1 1
2 0
"""
from pandas import DataFrame

data = {k: v.array.to_dense() for k, v in self._parent.items()}
return DataFrame(data, index=self._parent.index, columns=self._parent.columns)
return self._parent._constructor(
data, index=self._parent.index, columns=self._parent.columns)

def to_coo(self) -> spmatrix:
"""
Expand Down
4 changes: 4 additions & 0 deletions pandas/tests/arrays/sparse/test_accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,7 @@ def test_with_column_named_sparse(self):
# https://github.com/pandas-dev/pandas/issues/30758
df = pd.DataFrame({"sparse": pd.arrays.SparseArray([1, 2])})
assert isinstance(df.sparse, pd.core.arrays.sparse.accessor.SparseFrameAccessor)

def test_subclassing(self):
df = tm.SubclassedDataFrame({"sparse": pd.arrays.SparseArray([1, 2])})
assert isinstance(df.sparse.to_dense(), tm.SubclassedDataFrame)