BUG: Fix SparseFrameAccessor.to_dense return type #59967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
fix-sparse-accessor-to-dense
branch
2 times, most recently
from
71a633d
to
fea6dd8
Compare
mroeschke
reviewed
Oct 4, 2024
Comment on lines
257
to
263
| class SubclassedDataFrame(pd.DataFrame): | ||
| @property | ||
| def _constructor(self): | ||
| return SubclassedDataFrame | ||
|
|
||
| df = SubclassedDataFrame({"sparse": pd.arrays.SparseArray([1, 2])}) | ||
| assert isinstance(df.sparse.to_dense(), SubclassedDataFrame) |
There was a problem hiding this comment.
Suggested change
| class SubclassedDataFrame(pd.DataFrame): | |
| @property | |
| def _constructor(self): | |
| return SubclassedDataFrame | |
| df = SubclassedDataFrame({"sparse": pd.arrays.SparseArray([1, 2])}) | |
| assert isinstance(df.sparse.to_dense(), SubclassedDataFrame) | |
| df = tm.SubclassedDataFrame({"sparse": pd.arrays.SparseArray([1, 2])}) | |
| assert isinstance(df.sparse.to_dense(), tm.SubclassedDataFrame) |
There was a problem hiding this comment.
Thanks, I didn't know it's already there.
mroeschke
reviewed
Oct 4, 2024
| @@ -369,10 +369,9 @@ def to_dense(self) -> DataFrame: | |||
| 1 1 | |||
| 2 0 | |||
| """ | |||
| from pandas import DataFrame | |||
|
|
|||
| constructor = self._parent._constructor | |||
There was a problem hiding this comment.
Nit: Could you inline this on the return line?
janezd
force-pushed
the
fix-sparse-accessor-to-dense
branch
from
fea6dd8
to
10b2363
Compare
janezd
commented
Oct 4, 2024
Comment on lines
257
to
263
| class SubclassedDataFrame(pd.DataFrame): | ||
| @property | ||
| def _constructor(self): | ||
| return SubclassedDataFrame | ||
|
|
||
| df = SubclassedDataFrame({"sparse": pd.arrays.SparseArray([1, 2])}) | ||
| assert isinstance(df.sparse.to_dense(), SubclassedDataFrame) |
There was a problem hiding this comment.
Thanks, I didn't know it's already there.
| @@ -369,10 +369,9 @@ def to_dense(self) -> DataFrame: | |||
| 1 1 | |||
| 2 0 | |||
| """ | |||
| from pandas import DataFrame | |||
|
|
|||
| constructor = self._parent._constructor | |||
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Oct 4, 2024
|
Thanks @janezd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile