REGR: Avoid regression warning with ea dtype and assert_index_equal order False #47325

phofl · 2022-06-13T07:43:16Z

closes BUG: assert_index_equal raises FutureWarning when comparing Index of Int64Dtype without checking order #47207 (Replace xxxx with the Github issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

…rder False

simonjayhawkins · 2022-06-13T08:50:11Z

pandas/_testing/asserters.py

-        left = Index(safe_sort(left))
-        right = Index(safe_sort(right))
+        left = Index(safe_sort(left), dtype=left.dtype)
+        right = Index(safe_sort(right), dtype=right.dtype)


maybe another issue, but the check_names check is later. It maybe that would need to resuse the code pattern you added in #47206. Not here, as this PR is targeted 1.4.3, just an observation.

Good point, I am not using that myself, so I am a bit fuzzy on all the keywords :)

It is actually a bit more comlex, because These calls return regular indexes, even if a MultiIndex was given. I'll open an issue about it

Edit: Sorry misunderstood you. You are correct, we have to use exactly the same pattern

my thinking was that your fix in #47206 looked quite useful to robustly sort indexes. and maybe a safe_sort_index would be handy. (IIRC we cannot support pandas objects in safe_sort but would need to check this). I wonder can the fix in #47206 suffer from the rogue warning too without the dtype specified there?

Yep you are completely right. Opened #47330 for 1.5

simonjayhawkins · 2022-06-13T18:22:52Z

doc/source/whatsnew/v1.4.3.rst

@@ -24,6 +24,7 @@ Fixed regressions
 - Fixed regression in :func:`read_csv` with ``index_col=False`` identifying first row as index names when ``header=None`` (:issue:`46955`)
 - Fixed regression in :meth:`.DataFrameGroupBy.agg` when used with list-likes or dict-likes and ``axis=1`` that would give incorrect results; now raises ``NotImplementedError`` (:issue:`46995`)
 - Fixed regression in :meth:`DataFrame.resample` and :meth:`DataFrame.rolling` when used with list-likes or dict-likes and ``axis=1`` that would raise an unintuitive error message; now raises ``NotImplementedError`` (:issue:`46904`)
+- Fixed regression in :func:`assert_index_equal` when ``check_order=False`` and :class:`Index` has extension dtype (:issue:`47207`)


I think I may have been wrong to add the regression label to #47207

Not strictly a regression since 1.3.5 did not have EA backed Indexes and the code sample created an object dtype Index. maybe this should be in the bugfix section. wdyt?

You are correct wrt ea back indexes, but you can also trigger this with

idx1 = pd.Index([1, 3], dtype="object") idx2 = pd.Index([3, 1], dtype="object") tm.assert_index_equal(idx1, idx2, check_order=False)

I'll add a test and will adjust the release note

simonjayhawkins · 2022-06-15T06:46:05Z

pandas/tests/util/test_assert_index_equal.py

+    tm.assert_index_equal(idx1, idx2, check_order=False)
+
+
+def test_assert_index_equal_object_ints_order_false(any_numeric_ea_dtype):


don't need the fixture otherwise lgtm.

Thx, good point. Removed.

simonjayhawkins

Thanks @phofl lgtm

jreback · 2022-06-15T11:48:16Z

thanks @phofl

…dtype and assert_index_equal order False

jreback · 2022-06-15T11:48:39Z

@meeseeksdev backport 1.4.x

lumberbot-app · 2022-06-15T11:48:44Z

Could not push to auto-backport-of-pr-47325-on-1.4.x due to error, aborting.

simonjayhawkins · 2022-06-15T13:06:51Z

doc/source/whatsnew/v1.4.3.rst

@@ -24,6 +24,7 @@ Fixed regressions
 - Fixed regression in :func:`read_csv` with ``index_col=False`` identifying first row as index names when ``header=None`` (:issue:`46955`)
 - Fixed regression in :meth:`.DataFrameGroupBy.agg` when used with list-likes or dict-likes and ``axis=1`` that would give incorrect results; now raises ``NotImplementedError`` (:issue:`46995`)
 - Fixed regression in :meth:`DataFrame.resample` and :meth:`DataFrame.rolling` when used with list-likes or dict-likes and ``axis=1`` that would raise an unintuitive error message; now raises ``NotImplementedError`` (:issue:`46904`)
+- Fixed regression in :func:`assert_index_equal` when ``check_order=False`` and :class:`Index` has extension or object dtype (:issue:`47207`)


@phofl FYI :func:`assert_index_equal` doesn't render. probably needs to be :func:`testing.assert_index_equal` .

no need to follow-up as can be done with other cleanups before release.

Thanks, will try to do correctly in the future

…th ea dtype and assert_index_equal order False) (#47366) Backport PR #47325: REGR: Avoid regression warning with ea dtype and assert_index_equal order False Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>

…rder False (pandas-dev#47325)

REGR: Avoid regression warning with ea dtype and assert_index_equal o…

4e98bad

…rder False

phofl added Testing pandas testing functions or related to the test suite Regression Functionality that used to work in a prior pandas version labels Jun 13, 2022

phofl added this to the 1.4.3 milestone Jun 13, 2022

simonjayhawkins reviewed Jun 13, 2022

View reviewed changes

phofl mentioned this pull request Jun 13, 2022

BUG: assert_index_equal ignoring names when check_order is false #47330

Merged

5 tasks

simonjayhawkins mentioned this pull request Jun 13, 2022

BUG: concat losing column dtype for extension arrays and object dtype #47329

Closed

3 tasks

simonjayhawkins reviewed Jun 13, 2022

View reviewed changes

Add test

aa6e165

simonjayhawkins reviewed Jun 15, 2022

View reviewed changes

Remove fixture

5879fb4

simonjayhawkins approved these changes Jun 15, 2022

View reviewed changes

jreback merged commit 7c6a76a into pandas-dev:main Jun 15, 2022

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 15, 2022

Backport PR pandas-dev#47325: REGR: Avoid regression warning with ea …

e4836bb

…dtype and assert_index_equal order False

meeseeksmachine mentioned this pull request Jun 15, 2022

Backport PR #47325 on branch 1.4.x (REGR: Avoid regression warning with ea dtype and assert_index_equal order False) #47366

Merged

phofl deleted the 47207 branch June 15, 2022 11:49

simonjayhawkins reviewed Jun 15, 2022

View reviewed changes

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022

REGR: Avoid regression warning with ea dtype and assert_index_equal o…

b85e1e3

…rder False (pandas-dev#47325)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

REGR: Avoid regression warning with ea dtype and assert_index_equal order False #47325

REGR: Avoid regression warning with ea dtype and assert_index_equal order False #47325

phofl commented Jun 13, 2022

simonjayhawkins Jun 13, 2022

phofl Jun 13, 2022 •

edited

Loading

simonjayhawkins Jun 13, 2022

phofl Jun 13, 2022

simonjayhawkins Jun 13, 2022

phofl Jun 14, 2022

phofl Jun 14, 2022

simonjayhawkins Jun 15, 2022

phofl Jun 15, 2022

simonjayhawkins left a comment

jreback commented Jun 15, 2022

jreback commented Jun 15, 2022

lumberbot-app bot commented Jun 15, 2022

simonjayhawkins Jun 15, 2022

phofl Jun 15, 2022

		tm.assert_index_equal(idx1, idx2, check_order=False)


		def test_assert_index_equal_object_ints_order_false(any_numeric_ea_dtype):

REGR: Avoid regression warning with ea dtype and assert_index_equal order False #47325

REGR: Avoid regression warning with ea dtype and assert_index_equal order False #47325

Conversation

phofl commented Jun 13, 2022

Choose a reason for hiding this comment

phofl Jun 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simonjayhawkins left a comment

Choose a reason for hiding this comment

jreback commented Jun 15, 2022

jreback commented Jun 15, 2022

lumberbot-app bot commented Jun 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phofl Jun 13, 2022 •

edited

Loading