Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGR: concat not sorting columns for mixed column names #47206

Merged
merged 3 commits into from
Jun 5, 2022
Merged

REGR: concat not sorting columns for mixed column names #47206

merged 3 commits into from
Jun 5, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jun 3, 2022

The except clause can be removed in 1.5 through handling cases like [1, "a", None] in algorithms, but this would change the behavior a bit so would avoid backporting

@phofl phofl added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Regression Functionality that used to work in a prior pandas version labels Jun 3, 2022
@phofl phofl added this to the 1.4.3 milestone Jun 3, 2022
simonjayhawkins
simonjayhawkins reviewed Jun 3, 2022
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl

pandas/core/indexes/api.py Outdated
@@ -154,7 +155,11 @@ def _get_combined_index(

if sort:
try:
index = index.sort_values()
index_sorted = safe_sort(index)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for clarity, can you rename index_sorted as the return type from safe_sort is an numpy array and not an index.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done

@jreback jreback merged commit a54ac87 into pandas-dev:main Jun 5, 2022
@jreback
Copy link
Contributor

jreback commented Jun 5, 2022

very nice @phofl

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 5, 2022
@phofl @meeseeksmachine
Backport PR pandas-dev#47206: REGR: concat not sorting columns for mi…
368b846 
…xed column names
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 5, 2022
Merged
@jreback
Copy link
Contributor

jreback commented Jun 5, 2022

@meeseeksdev backport 1.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 5, 2022

Could not push to auto-backport-of-pr-47206-on-1.4.x due to error, aborting.

simonjayhawkins pushed a commit that referenced this pull request Jun 6, 2022
@meeseeksmachine @phofl
Backport PR #47206 on branch 1.4.x (REGR: concat not sorting columns …
75a799c 
…for mixed column names) (#47251)

Backport PR #47206: REGR: concat not sorting columns for mixed column names

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@phofl phofl deleted the 47127 branch June 6, 2022 20:48
This was referenced Jun 13, 2022
Merged
Closed
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 27, 2022
Closed
3 tasks
@orbeckst orbeckst mentioned this pull request Jun 30, 2022
Merged
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@phofl @yehoshuadimarsky
REGR: concat not sorting columns for mixed column names (pandas-dev#4…
4c4100f 
…7206)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

Assignees
No one assigned
Labels
Regression Functionality that used to work in a prior pandas version Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.

BUG: concat column order behaviors changes after 1.4
3 participants
@phofl @jreback @simonjayhawkins