BUG: Series.where casting dt64 to int64 #38073
Conversation
jreback
added
Indexing
…g-series-where
|
@jreback just rebased with a fix for the unused import in groupby.py |
|
@jreback gentle ping; in addition to being a bug this is a blocker for further simplification in blocks |
…g-series-where
|
merge master on this |
…g-series-where
|
rebased+green |
…g-series-where
|
rebased+green |
…g-series-where
| self, other, cond, errors="raise", try_cast: bool = False, axis: int = 0 | ||
| ) -> List["Block"]: | ||
| # TODO(EA2D): reshape unnecessary with 2D EAs | ||
| arr = self.array_values().reshape(self.shape) |
There was a problem hiding this comment.
you can almost use your ravel_compat decorator
| @@ -464,3 +464,34 @@ def test_where_categorical(klass): | |||
| df = klass(["A", "A", "B", "B", "C"], dtype="category") | |||
| res = df.where(df != "C") | |||
| tm.assert_equal(exp, res) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("tz", [None, "US/Pacific"]) | |||
There was a problem hiding this comment.
could use the timezone fixtures, but nbd
…g-series-where
…g-series-where
…g-series-where
pandas/core/internals/blocks.py
Outdated
| cond = cond.T | ||
|
|
||
| if not hasattr(cond, "shape"): | ||
| raise ValueError("where must have a condition that is ndarray like") |
There was a problem hiding this comment.
is this actually hit? shouldn't this be an assertion (i know this is friendler of course), but still.
There was a problem hiding this comment.
actually you explicity check this on L1347 no?
There was a problem hiding this comment.
good catch, will remove
| @@ -278,7 +278,7 @@ def test_array_inference_fails(data): | |||
| tm.assert_extension_array_equal(result, expected) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("data", [np.array([[1, 2], [3, 4]]), [[1, 2], [3, 4]]]) | |||
| @pytest.mark.parametrize("data", [np.array(0)]) | |||
There was a problem hiding this comment.
we pass thru 2-D pandas arrays?
There was a problem hiding this comment.
DTA/TDA._validate_listlike calls pd.array on possibly-2D inputs, which go through PandasArray
| @@ -464,3 +464,34 @@ def test_where_categorical(klass): | |||
| df = klass(["A", "A", "B", "B", "C"], dtype="category") | |||
| res = df.where(df != "C") | |||
| tm.assert_equal(exp, res) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("tz", [None, "US/Pacific"]) | |||
…g-series-where
|
let's rebase one more time after your _where change was merged; ping on green |
…g-series-where
|
ping |
* ENH: support 2D in DatetimeArray._from_sequence * BUG: Series.where casting dt64 to int64 * whatsnew * move whatsnew * use fixture, remove unnecessary check
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis sits on top of #38021