Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: support 2D in DatetimeArray._from_sequence #38021

Merged
merged 1 commit into from
Dec 17, 2020
Merged

ENH: support 2D in DatetimeArray._from_sequence #38021

merged 1 commit into from
Dec 17, 2020

Conversation

jbrockmendel
Copy link
Member

Broken off from a branch that fixes #37682, the constraint on which is that _validate_setitem_value needs to handle 2D.

jorisvandenbossche
jorisvandenbossche requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #37950, I am personally not convinced we should expand the 2D capabilities.

@jbrockmendel
Copy link
Member Author

Thank you for weighing in Joris. As I said in the OP, this is part of fixing #37682.

@jbrockmendel jbrockmendel mentioned this pull request Nov 25, 2020
Merged
5 tasks
@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

hmm, yeah i think i agree with @jorisvandenbossche here, we should either go all in on 2D or not. can we just process column by column instead?

@jbrockmendel
Copy link
Member Author

can we just process column by column instead?

we can, but it means putting more logic in Blocks which is the opposite of what im trying to do

@jreback jreback added this to the 1.3 milestone Dec 13, 2020
@jreback jreback added the Refactor Internal refactoring of code label Dec 13, 2020
@jreback
Copy link
Contributor

jreback commented Dec 13, 2020

looking at this again it is fine. we do this in all kinds of places where we can potentially have 1d or 2d inputs.

unless objecting by @jorisvandenbossche and i think would need a concrete proposal that acheives the same aim, will merge tomorrow.

@jbrockmendel jbrockmendel mentioned this pull request Dec 17, 2020
Merged
5 tasks
@jreback jreback merged commit baeacad into pandas-dev:master Dec 17, 2020
@jreback
Copy link
Contributor

jreback commented Dec 17, 2020

this is fine

@jbrockmendel jbrockmendel mentioned this pull request Dec 17, 2020
Closed
@jbrockmendel jbrockmendel deleted the enh-dta-from_sequence-2d branch December 17, 2020 15:44
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
@jbrockmendel @luckyvs1
ENH: support 2D in DatetimeArray._from_sequence (pandas-dev#38021)
13825eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche requested changes

Assignees
No one assigned
Labels
Enhancement Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

BUG: Index.where vs Series.where mismatch
3 participants
@jbrockmendel @jreback @jorisvandenbossche