-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #37198 on branch 1.1.x (BUG: Regression in Resample.apply raised error when apply affected only a Series) #37305
Backport PR #37198 on branch 1.1.x (BUG: Regression in Resample.apply raised error when apply affected only a Series) #37305
Conversation
…d error when apply affected only a Series
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO NOT MERGE - failures are not false positives
Was this introduced through my fix or did I use something, which is only working on master and not 1.1.4? |
not got to the bottom of it yet. see #36951 (comment) |
Not off the top of my head, no. |
appears to be #35792 https://github.com/simonjayhawkins/pandas/runs/1305349161?check_suite_focus=true |
looks like #35792 can be backported without any conflicts (except release note). added here for ci checking. would backport independently if moving forward with this. (whatsnew would need to be changed on master) depending on tests passing, 3 options.
|
@jreback OK with option 3 #37305 (comment) will start on a separate backport PR #35792 and PR to move the whatsnew |
This reverts commit 1dc0795.
Backport PR #37198: BUG: Regression in Resample.apply raised error when apply affected only a Series