Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #37198 on branch 1.1.x (BUG: Regression in Resample.apply raised error when apply affected only a Series) #37305

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #37198: BUG: Regression in Resample.apply raised error when apply affected only a Series

@lumberbot-app lumberbot-app bot added this to the 1.1.4 milestone Oct 21, 2020
@simonjayhawkins simonjayhawkins added Apply Apply, Aggregate, Transform, Map Resample resample method labels Oct 21, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE - failures are not false positives

@phofl
Copy link
Member

phofl commented Oct 21, 2020

Was this introduced through my fix or did I use something, which is only working on master and not 1.1.4?

@simonjayhawkins
Copy link
Member

Was this introduced through my fix or did I use something, which is only working on master and not 1.1.4?

not got to the bottom of it yet. see #36951 (comment)

@jbrockmendel
Copy link
Member

any ideas where changes in master could have corrected this

Not off the top of my head, no.

simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Oct 25, 2020
@simonjayhawkins
Copy link
Member

any ideas where changes in master could have corrected this

Not off the top of my head, no.

appears to be #35792

https://github.com/simonjayhawkins/pandas/runs/1305349161?check_suite_focus=true

@simonjayhawkins
Copy link
Member

simonjayhawkins commented Oct 26, 2020

looks like #35792 can be backported without any conflicts (except release note). added here for ci checking. would backport independently if moving forward with this. (whatsnew would need to be changed on master)

depending on tests passing, 3 options.

  1. don't backport BUG: Regression in Resample.apply raised error when apply affected only a Series #37198 (see REGR: resample apply fails with KeyError/AttributeError for function that works on DataFrame but fails on Series #36951 (comment) this regression is from 0.25.3 to 1.0.0, we could decide not to backport.)

  2. backport BUG: Regression in Resample.apply raised error when apply affected only a Series #37198 and change tests to not check frequency of index on backport only.

  3. backport BUG: Regression in Resample.apply raised error when apply affected only a Series #37198 and CLN/BUG: Clean/Simplify _wrap_applied_output #35792 (which fixes bug for Categoricalndex and preserves freq in DatetimeIndex following DataFrameGroupby)

@simonjayhawkins
Copy link
Member

@jreback OK with option 3 #37305 (comment)

will start on a separate backport PR #35792 and PR to move the whatsnew

@simonjayhawkins simonjayhawkins mentioned this pull request Oct 26, 2020
@simonjayhawkins simonjayhawkins merged commit 5498df4 into pandas-dev:1.1.x Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Resample resample method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants