CLN/BUG: Clean/Simplify _wrap_applied_output #35792
Conversation
|
cc @WillAyd @jbrockmendel @jreback mac timed out, but otherwise green. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks @WillAyd for restarting the test. Passing now. |
|
Hello @rhshadrach! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-08-26 02:38:15 UTC |
…rap_apply_cleanup � Conflicts: � doc/source/whatsnew/v1.2.0.rst
|
@jreback - comment added; only failures are due to pyarrow. Edit: Reran Travis, all green now. |
|
Benchmarks ran, no errors, and no significant performance changes.
|
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -251,6 +251,7 @@ Groupby/resample/rolling | |||
| - Bug in :meth:`DataFrameGroupBy.apply` that would some times throw an erroneous ``ValueError`` if the grouping axis had duplicate entries (:issue:`16646`) | |||
| - Bug when combining methods :meth:`DataFrame.groupby` with :meth:`DataFrame.resample` and :meth:`DataFrame.interpolate` raising an ``TypeError`` (:issue:`35325`) | |||
| - Bug in :meth:`DataFrameGroupBy.apply` where a non-nuisance grouping column would be dropped from the output columns if another groupby method was called before ``.apply()`` (:issue:`34656`) | |||
| - Bug in :meth:`DataFrameGroupby.apply` would drop a :class:`CategoricalIndex` when grouped on. | |||
There was a problem hiding this comment.
can you add the issue number here (in this case use this PR number as there isn't an issue)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…rap_apply_cleanup
|
Thanks @jreback, merged. |
|
@rhshadrach as a rule of thumb, we try not to merge our own PRs |
|
@meeseeksdev backport 1.1.x This will fail but give instructions |
This comment has been minimized.
This comment has been minimized.
… _wrap_applied_output
This reverts commit 1dc0795.
…lied_output (#37416) Co-authored-by: Richard Shadrach <45562402+rhshadrach@users.noreply.github.com>
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFirst part of #35412. I could not find a relevant issue for the test change/whatsnew update.