Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix syntax error in groupby docs #23498

Merged

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 4, 2018

https://travis-ci.org/pandas-dev/pandas/jobs/450582832

#15559 has been rearing its head again. Turns out the reason for the timeout is one silly, missing parenthesis in the groupby.rst docs (that was the cause as well in #15506). 😆

Follow-up to #23394.

@gfyoung gfyoung added Bug Docs CI Continuous Integration labels Nov 4, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 4, 2018
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe make this actually do something? e.g .sum() to show the resulting frame

@gfyoung
Copy link
Member Author

gfyoung commented Nov 4, 2018

maybe make this actually do something? e.g .sum() to show the resulting frame

@jreback : That's fair. I do want to make sure that the Travis build first doesn't timeout. Then we can add something to show the result.

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #23498 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23498   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51197    51197           
=======================================
  Hits        47220    47220           
  Misses       3977     3977
Flag Coverage Δ
#multiple 90.61% <ø> (ø) ⬆️
#single 42.27% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24ab22f...5248094. Read the comment docs.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gfyoung
Copy link
Member Author

gfyoung commented Nov 5, 2018

@jreback : Made the suggested change, and all builds (including the doc build) are green. PTAL.

@jorisvandenbossche jorisvandenbossche merged commit 0bb24b7 into pandas-dev:master Nov 5, 2018
@jorisvandenbossche
Copy link
Member

@gfyoung Thanks for finding the trigger for the doc time out! Luckily it was something very simple in the end ;) (I still don't understand how this caused such a slow down without giving actual errors)

(but maybe in the future if you are re-doing a PR that broke the doc build, make sure to check if now the doc build is actually working .. :))

@gfyoung
Copy link
Member Author

gfyoung commented Nov 5, 2018

(but maybe in the future if you are re-doing a PR that broke the doc build, make sure to check if now the doc build is actually working .. :))

@jorisvandenbossche : The doc builds were working in fact when I first opened the PR. It was a mysterious bug that reared its head in strange ways. 🙂

@jorisvandenbossche
Copy link
Member

@gfyoung yeah, I can only see the status of the last commit (in general, can you start adding new commits instead of rebasing/amending a single commit in a PR ?), and there it was actually failing, although it looks green. I think we discussed that before, but we should probably move the doc build out of "allowed failures".

thoo added a commit to thoo/pandas that referenced this pull request Nov 5, 2018
…fixed

* upstream/master:
  Run Isort on tests-> util,sereis,arrays (pandas-dev#23501)
  DOC: Fix syntax error in groupby docs (pandas-dev#23498)
  DOC: Fix DataFrame.nlargest and DataFrame.nsmallest doctests (pandas-dev#23202)
  DOC: Remove dead link and update links to https (pandas-dev#23476)
@gfyoung gfyoung deleted the doc-build-timeout branch November 6, 2018 04:19
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants