ENH: Add FrozenList.union and .difference #23394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @gfyoung! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23394 +/- ##
==========================================
+ Coverage 92.21% 92.21% +<.01%
==========================================
Files 161 161
Lines 51187 51191 +4
==========================================
+ Hits 47202 47206 +4
Misses 3985 3985
Continue to review full report at Codecov.
|
|
@jreback @jorisvandenbossche : Any thoughts on this? |
gfyoung
force-pushed
the
frozen-list-union-diff
branch
from
570e9e3
to
0468d9a
Compare
jreback
reviewed
Nov 1, 2018
Re-attempt of pandas-devgh-15506. Closes pandas-devgh-15475.
gfyoung
force-pushed
the
frozen-list-union-diff
branch
from
0468d9a
to
c1a375e
Compare
|
@jreback : Changes addressed, and all is green. PTAL. |
|
@jreback : Any thoughts on this? |
|
LGTM |
jreback
approved these changes
Nov 3, 2018
|
thanks @gfyoung |
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Nov 3, 2018
…xamples * repo_org/master: (66 commits) CLN: doc string (pandas-dev#23469) DOC: Add cookbook entry for triangular correlation matrix (GH22840) (pandas-dev#23032) add number of Errors, Warnings to scripts/validate_docstrings.py (pandas-dev#23150) BUG: Allow freq conversion from dt64 to period (pandas-dev#23460) ENH: Add FrozenList.union and .difference (pandas-dev#23394) REF: cython cleanup, typing, optimizations (pandas-dev#23464) strictness and checks for Timedelta _simple_new (pandas-dev#23433) Fixing flake8 problems new to flake8 3.6.0 (pandas-dev#23472) DOC: Updating the docstring of Series.dot (pandas-dev#22890) TST: Fixturize series/test_analytics.py (pandas-dev#22755) BUG/ENH: Handle NonexistentTimeError in date rounding (pandas-dev#23406) PERF: speed up concat on Series by making _get_axis_number() a classmethod (pandas-dev#23404) REF: Remove DatetimelikeArrayMixin._shallow_copy (pandas-dev#23430) REF: strictness/simplification in DatetimeArray/Index _simple_new (pandas-dev#23431) REF: cython cleanup, typing, optimizations (pandas-dev#23456) TST: tweak Hypothesis configuration and idioms (pandas-dev#23441) BUG: fix HDFStore.append with all empty strings error (GH12242) (pandas-dev#23435) TST: Skip 32bit failing IntervalTree tests (pandas-dev#23442) BUG: Deprecate nthreads argument (pandas-dev#23112) style: fix import format at pandas/core/reshape (pandas-dev#23387) ...
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Nov 4, 2018
This reverts commit 06c8643.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Nov 4, 2018
This reverts commit 06c8643.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Nov 4, 2018
This reverts commit 06c8643.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Nov 4, 2018
Follow-up to pandas-devgh-23394.
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Nov 4, 2018
Follow-up to pandas-devgh-23394.
jorisvandenbossche
pushed a commit
that referenced
this pull request
Nov 5, 2018
Follow-up to gh-23394.
| - ``ExcelWriter`` now accepts ``mode`` as a keyword argument, enabling append to existing workbooks when using the ``openpyxl`` engine (:issue:`3441`) | ||
|
|
||
| - ``FrozenList`` has gained the ``.union()`` and ``.difference()`` methods. This functionality greatly simplifies groupby's that rely on explicitly excluding certain columns. See :ref:`Splitting an object into groups |
There was a problem hiding this comment.
This still uses FrozenList, a term that is nowhere mentioned currently in the docs.
Personally, that also indicates a problem with this feature for me. I think we should either properly document FrozenList its methods in the pandas API, or either not have additional methods on it (compared to list).
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
Re-attempt of pandas-devgh-15506. Closes pandas-devgh-15475.
JustinZhengBC
pushed a commit
to JustinZhengBC/pandas
that referenced
this pull request
Nov 14, 2018
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Re-attempt of pandas-devgh-15506. Closes pandas-devgh-15475.
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Re-attempt of pandas-devgh-15506. Closes pandas-devgh-15475.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Re-attempt of pandas-devgh-15506. Closes pandas-devgh-15475.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-attempt of #15506.
Hopefully no doc slowdowns on Travis this time 🙏 ! (xref #15559)
Closes #15475.
No deprecation of
__add__and__iadd__because we rely on overloading+internally when operating on array-likes (in general) in some cases (e.g. here). In some cases, that array-like will beFrozenList.