Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: pyarrow 0.6.0 compat, we need to handle back-compat on this #17438

Closed
jreback opened this issue Sep 5, 2017 · 2 comments · Fixed by #17447
Closed

CLN: pyarrow 0.6.0 compat, we need to handle back-compat on this #17438

jreback opened this issue Sep 5, 2017 · 2 comments · Fixed by #17447
Labels
Compat pandas objects compatability with Numpy or Python functions IO Parquet parquet, feather
Milestone
0.21.0

Comments

@jreback
Copy link
Contributor

jreback commented Sep 5, 2017

/home/travis/miniconda3/envs/pandas/lib/python3.6/site-packages/pyarrow/pandas_compat.py:248: FutureWarning: timestamps_to_ms=True is deprecated
warnings.warn('timestamps_to_ms=True is deprecated', FutureWarning)
@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Sep 5, 2017
@jreback jreback added this to the 0.21.0 milestone Sep 5, 2017
@jreback
Copy link
Contributor Author

jreback commented Sep 5, 2017

cc @wesm

@jreback jreback mentioned this issue Sep 5, 2017
Closed
@wesm
Copy link
Member

wesm commented Sep 5, 2017

per discussion in apache/arrow#1046, I think the correct fix is to remove usage of timestamps_to_ms in pandas and pass the right coercion option to pyarrow.parquet.write_table

jreback added a commit to jreback/pandas that referenced this issue Sep 6, 2017
@jreback
COMPAT: handle pyarrow deprecation of timestamps_to_ms in .from_panda…
ea2ff0c 
…s with pyarrow < 0.6.0

closes pandas-dev#17438
@jreback jreback mentioned this issue Sep 6, 2017
Merged
jreback added a commit that referenced this issue Sep 6, 2017
@jreback
COMPAT: handle pyarrow deprecation of timestamps_to_ms in .from_panda…
84a39f9 
…s with pyarrow < 0.6.0 (#17447)

closes #17438
@jreback jreback added the IO Parquet parquet, feather label Sep 6, 2017
@jreback jreback mentioned this issue Sep 6, 2017
Closed
3 tasks
wesm pushed a commit to wesm/arrow that referenced this issue Sep 7, 2017
@jreback @wesm
ARROW-622 [Python] deprecate timestamps_to_ms in .from_pandas()
b698227 
xref pandas-dev/pandas#17438

this was not fully resolved in apache#944

Author: Jeff Reback <jeff@reback.net>

Closes apache#1046 from jreback/warn and squashes the following commits:

382592f [Jeff Reback] deprecate timestamps_to_ms in .from_pandas()
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this issue Sep 10, 2017
@jreback @jbrockmendel
COMPAT: handle pyarrow deprecation of timestamps_to_ms in .from_panda…
07edd07 
…s with pyarrow < 0.6.0 (pandas-dev#17447)

closes pandas-dev#17438
jowens pushed a commit to jowens/pandas that referenced this issue Sep 20, 2017
@jreback @jowens
COMPAT: handle pyarrow deprecation of timestamps_to_ms in .from_panda…
8edd85a 
…s with pyarrow < 0.6.0 (pandas-dev#17447)

closes pandas-dev#17438
alanbato pushed a commit to alanbato/pandas that referenced this issue Nov 10, 2017
@jreback @alanbato
COMPAT: handle pyarrow deprecation of timestamps_to_ms in .from_panda…
d7d7143 
…s with pyarrow < 0.6.0 (pandas-dev#17447)

closes pandas-dev#17438
No-Stream pushed a commit to No-Stream/pandas that referenced this issue Nov 28, 2017
@jreback @No-Stream
COMPAT: handle pyarrow deprecation of timestamps_to_ms in .from_panda…
88d94e8 
…s with pyarrow < 0.6.0 (pandas-dev#17447)

closes pandas-dev#17438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions IO Parquet parquet, feather
Projects
None yet
Milestone
0.21.0
2 participants
@wesm @jreback