ARROW-622 [Python] deprecate timestamps_to_ms in .from_pandas() #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
commented
Sep 5, 2017
python/pyarrow/table.pxi
Outdated
| @@ -701,18 +701,25 @@ cdef class Table: | |||
| return result | |||
|
|
|||
| @classmethod | |||
| def from_pandas(cls, df, bint timestamps_to_ms=False, | |||
| def from_pandas(cls, df, | |||
| object coerce_timestamps=False, object timestamps_to_ms=None, | |||
There was a problem hiding this comment.
note that the signature is slightly changed here; I could add the new argument at the end if you prefer.
|
green other that a stalled build: https://travis-ci.org/apache/arrow/jobs/272034734 |
wesm
reviewed
Sep 5, 2017
python/pyarrow/array.pxi
Outdated
| Convert datetime columns to the indicated resolution. If False | ||
| preserve the existing dtype. | ||
| This is needed for compability with other functionality like | ||
| Parquet I/O which only supports milliseconds / microseconds. |
There was a problem hiding this comment.
I don't think this is the right fix. The coercion happens in parquet.write_table
|
ok this is more limited in scope, removing test warnings for using I'll fix the deprecation issue in .to_parquet on the pandas side itself. |
|
LGTM. The build is failing due to a Sphinx warning, can you fix that? |
|
+1. Build failed due to stalled macos image and maven central flakiness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref pandas-dev/pandas#17438
this was not fully resolved in #944