This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Fatal errors from API should be unhandled and caught in tslint-cli #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1759
3rd party apps should be able to see the fatal errors thrown by the API. #1686 changed it so that the error was caught and added as a property to IConfigurationLoadResult. It's not reasonable for 3rd party apps to be aware of this property, so we should follow convention and throw an unhandled exception that the app itself can handle.
This change creates a new FatalError class which is caught in
tslint.cli.