This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Slightly better error for failed tslint.json parses #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1681 `configuration`'s `findConfiguration` now returns a result wrapper with the attempted `path` as well as `error?` and `results?`. `tslint-cli` will log the failure nicely.
nchen63
suggested changes
Nov 10, 2016
|
@nchen63 added |
nchen63
reviewed
Nov 10, 2016
| assert.isNotNull(err, "process should exit with error"); | ||
| assert.strictEqual(err.code, 1, "error code should be 1"); | ||
|
|
||
| assert.include(stderr, "Invalid option for configuration", "stderr should contain notification about invalid json"); |
There was a problem hiding this comment.
this test isn't exercising the code in this PR. Invalid option for configuration is written when the config file is missing. I was expecting Failed to load <path>: <error message>
There was a problem hiding this comment.
You're right - that was sloppy. Should be fixed.
nchen63
approved these changes
Nov 12, 2016
|
@JoshuaKGoldberg thanks! |
This was referenced Nov 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1681
configuration'sfindConfigurationnow returns a result wrapper with the attemptedpathas well aserror?andresults?.tslint-cliwill log the failure nicely.