Skip to content

Commit

Permalink
[MINOR][TEST][DOC] Execute action miss name message
Browse files Browse the repository at this point in the history
## What changes were proposed in this pull request?

some minor updates:
- `Execute` action miss `name` message
-  typo in SS document
-  typo in SQLConf

## How was this patch tested?

N/A

Closes apache#24466 from uncleGen/minor-fix.

Authored-by: uncleGen <hustyugm@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
  • Loading branch information
uncleGen authored and mccheah committed May 24, 2019
1 parent e1a0ff6 commit c7e5d7e
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion docs/structured-streaming-programming-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -2980,7 +2980,7 @@ the effect of the change is not well-defined. For all of them:

- Changes to the user-defined foreach sink (that is, the `ForeachWriter` code) are allowed, but the semantics of the change depends on the code.

- *Changes in projection / filter / map-like operations**: Some cases are allowed. For example:
- *Changes in projection / filter / map-like operations*: Some cases are allowed. For example:

- Addition / deletion of filters is allowed: `sdf.selectExpr("a")` to `sdf.where(...).selectExpr("a").filter(...)`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2111,9 +2111,9 @@ class SQLConf extends Serializable with Logging {
def continuousStreamingExecutorPollIntervalMs: Long =
getConf(CONTINUOUS_STREAMING_EXECUTOR_POLL_INTERVAL_MS)

def userV1SourceReaderList: String = getConf(USE_V1_SOURCE_READER_LIST)
def useV1SourceReaderList: String = getConf(USE_V1_SOURCE_READER_LIST)

def userV1SourceWriterList: String = getConf(USE_V1_SOURCE_WRITER_LIST)
def useV1SourceWriterList: String = getConf(USE_V1_SOURCE_WRITER_LIST)

def disabledV2StreamingWriters: String = getConf(DISABLED_V2_STREAMING_WRITERS)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends Logging {
}

val useV1Sources =
sparkSession.sessionState.conf.userV1SourceReaderList.toLowerCase(Locale.ROOT).split(",")
sparkSession.sessionState.conf.useV1SourceReaderList.toLowerCase(Locale.ROOT).split(",")
val lookupCls = DataSource.lookupDataSource(source, sparkSession.sessionState.conf)
val cls = lookupCls.newInstance() match {
case f: FileDataSourceV2 if useV1Sources.contains(f.shortName()) ||
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {

val session = df.sparkSession
val useV1Sources =
session.sessionState.conf.userV1SourceWriterList.toLowerCase(Locale.ROOT).split(",")
session.sessionState.conf.useV1SourceWriterList.toLowerCase(Locale.ROOT).split(",")
val lookupCls = DataSource.lookupDataSource(source, session.sessionState.conf)
val cls = lookupCls.newInstance() match {
case f: FileDataSourceV2 if useV1Sources.contains(f.shortName()) ||
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ case class DataSourceResolution(

object V1WriteProvider {
private val v1WriteOverrideSet =
conf.userV1SourceWriterList.toLowerCase(Locale.ROOT).split(",").toSet
conf.useV1SourceWriterList.toLowerCase(Locale.ROOT).split(",").toSet

def unapply(provider: String): Option[String] = {
if (v1WriteOverrideSet.contains(provider.toLowerCase(Locale.ROOT))) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with Be
/** Execute arbitrary code */
object Execute {
def apply(name: String)(func: StreamExecution => Any): AssertOnQuery =
AssertOnQuery(query => { func(query); true }, "name")
AssertOnQuery(query => { func(query); true }, name)

def apply(func: StreamExecution => Any): AssertOnQuery = apply("Execute")(func)
}
Expand Down

0 comments on commit c7e5d7e

Please sign in to comment.