[MINOR][TEST][DOC] Execute action miss name message #24466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncleGen
changed the title
|
Test build #104929 has finished for PR 24466 at commit
|
|
retest this please |
|
Test build #104930 has finished for PR 24466 at commit
|
srowen
approved these changes
Apr 26, 2019
| @@ -294,7 +294,7 @@ trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with Be | |||
| /** Execute arbitrary code */ | |||
| object Execute { | |||
| def apply(name: String)(func: StreamExecution => Any): AssertOnQuery = | |||
| AssertOnQuery(query => { func(query); true }, "name") | |||
| AssertOnQuery(query => { func(query); true }, name) | |||
There was a problem hiding this comment.
CC @tdas for a double check but looks like a correct fix
|
Lgtm.
…On Fri, Apr 26, 2019, 12:38 PM Attila Zsolt Piros ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24466 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFB5LGU6YZY2YBCT74IYMLPSNKZZANCNFSM4HIS6CFA>
.
|
|
thanks, merging to master! |
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
May 24, 2019
## What changes were proposed in this pull request? some minor updates: - `Execute` action miss `name` message - typo in SS document - typo in SQLConf ## How was this patch tested? N/A Closes apache#24466 from uncleGen/minor-fix. Authored-by: uncleGen <hustyugm@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 6, 2019
## What changes were proposed in this pull request? some minor updates: - `Execute` action miss `name` message - typo in SS document - typo in SQLConf ## How was this patch tested? N/A Closes apache#24466 from uncleGen/minor-fix. Authored-by: uncleGen <hustyugm@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
some minor updates:
Executeaction missnamemessageHow was this patch tested?
N/A