Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][TEST][DOC] Execute action miss name message #24466

Closed
wants to merge 2 commits into from

Conversation

uncleGen
Copy link
Contributor

@uncleGen uncleGen commented Apr 26, 2019

What changes were proposed in this pull request?

some minor updates:

  • Execute action miss name message
  • typo in SS document
  • typo in SQLConf

How was this patch tested?

N/A

@uncleGen uncleGen changed the title [MINOR][SQL][DOC] Execute action miss name message [MINOR][TEST][DOC] Execute action miss name message Apr 26, 2019
@SparkQA
Copy link

SparkQA commented Apr 26, 2019

Test build #104929 has finished for PR 24466 at commit 41db4f5.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@uncleGen
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Apr 26, 2019

Test build #104930 has finished for PR 24466 at commit 41db4f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@uncleGen
Copy link
Contributor Author

uncleGen commented Apr 26, 2019

cc @cloud-fan @srowen

@@ -294,7 +294,7 @@ trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with Be
/** Execute arbitrary code */
object Execute {
def apply(name: String)(func: StreamExecution => Any): AssertOnQuery =
AssertOnQuery(query => { func(query); true }, "name")
AssertOnQuery(query => { func(query); true }, name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @tdas for a double check but looks like a correct fix

Copy link
Contributor

@attilapiros attilapiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdas
Copy link
Contributor

tdas commented Apr 26, 2019 via email

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 6328be7 Apr 27, 2019
mccheah pushed a commit to palantir/spark that referenced this pull request May 24, 2019
## What changes were proposed in this pull request?

some minor updates:
- `Execute` action miss `name` message
-  typo in SS document
-  typo in SQLConf

## How was this patch tested?

N/A

Closes apache#24466 from uncleGen/minor-fix.

Authored-by: uncleGen <hustyugm@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
mccheah pushed a commit to palantir/spark that referenced this pull request Jun 6, 2019
## What changes were proposed in this pull request?

some minor updates:
- `Execute` action miss `name` message
-  typo in SS document
-  typo in SQLConf

## How was this patch tested?

N/A

Closes apache#24466 from uncleGen/minor-fix.

Authored-by: uncleGen <hustyugm@gmail.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants