Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loggable exception assert for no args #607

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Add loggable exception assert for no args #607

merged 2 commits into from
Nov 9, 2021

Conversation

pkoenig10
Copy link
Member

Equivalent of palantir/conjure-java-runtime-api#702, but for loggable exceptions.

@changelog-app
Copy link

changelog-app bot commented Nov 9, 2021 •
edited by pkoenig10
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

LoggableExceptionAssert now contains a hasNoArgs method for asserting that an exception has no args.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from carterkozak November 9, 2021 13:45
@bulldozer-bot bulldozer-bot bot merged commit 797cb7a into develop Nov 9, 2021
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10/noArgs branch November 9, 2021 13:53
@svc-autorelease
Copy link
Collaborator

Released 1.20.0

@pkoenig10 pkoenig10 mentioned this pull request Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

@jkozlowski jkozlowski Awaiting requested review from jkozlowski

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkoenig10 @svc-autorelease @carterkozak @svc-changelog