Add error-prone check to prefer hasNoArgs #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Nov 9, 2021
baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/AssertNoArgsTest.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Nov 9, 2021
| "import com.palantir.logsafe.testing.LoggableExceptionAssert;", | ||
| "public class Test {", | ||
| " void f(LoggableExceptionAssert a) {", | ||
| " a.hasNoArgs();", |
There was a problem hiding this comment.
I think this one could produce failures, but I can't imagine anyone would write .containsArgs() and expect it to be a no-op.
There was a problem hiding this comment.
Searching our internal repos, I only see 2 uses of .containsArgs() without any arguments and they are both in a repo I own. And the intention in both cases was to assert that the exception has no args.
It's probably more likely that this change is a bug fix.
carterkozak
approved these changes
Nov 9, 2021
|
Released 4.39.0 |
carterkozak
reviewed
Nov 9, 2021
| linkType = BugPattern.LinkType.CUSTOM, | ||
| severity = BugPattern.SeverityLevel.WARNING, | ||
| summary = "Prefer hasNoArgs when asserting that an exception has no args.") | ||
| public final class AssertNoArgs extends BugChecker implements BugChecker.MethodInvocationTreeMatcher { |
There was a problem hiding this comment.
@pkoenig10 we probably should have added this to the BaselineErrorProneExtension so it's automatically fiexed
This was referenced Nov 9, 2021
Merged
bulldozer-bot bot
pushed a commit
to palantir/witchcraft-api
that referenced
this pull request
Nov 9, 2021
###### _excavator_ is a bot for automating changes across repositories. Changes produced by the roomba/latest-baseline-oss check. # Release Notes ## 4.38.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Improve Zero Warmup Rate Limiter to Catch Int Literals | palantir/gradle-baseline#1960 | ## 4.39.0 | Type | Description | Link | | ---- | ----------- | ---- | | Fix | The `com.palantir.baseline-java-versions` plugin requires gradle 7 and fails eagerly on older versions. Previously it would cause non-obvious failures later depending on task execution. | palantir/gradle-baseline#1965 | | Feature | Add Error Prone check to prefer `hasNoArgs` on service exception asserts and loggable exception asserts. | palantir/gradle-baseline#1966 | ## 4.40.0 | Type | Description | Link | | ---- | ----------- | ---- | | Improvement | Automatically fix AssertNoArgs | palantir/gradle-baseline#1967 | To enable or disable this check, please contact the maintainers of Excavator.
This was referenced Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error prone check to switch to the methods added in palantir/safe-logging#607 and palantir/conjure-java-runtime-api#702.
Probably want to wait a while before merging this so repos have upgraded to releases with the
hasNoArgsmethod.