Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with getReplacement when version is empty string #26

Merged
merged 2 commits into from
Feb 8, 2023
Merged

fix issue with getReplacement when version is empty string #26

merged 2 commits into from
Feb 8, 2023

Commits on Feb 8, 2023

  1. fix issue with getReplacement when version is empty string 

    It is possible that JakartaPackageAlignmentPlugin will call
getReplacement with an empty string for the version. Previously, this
code would erroneously return a replacement version because the
comparator for ComparableVersion returns -1 when an empty string is
compared with the maximum Jakarta version.

To address that, only look for a replacement when the version is
non-null and non-empty.

Fixes #25
    Brian Laub committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8f9b9ef View commit details
    Browse the repository at this point in the history

  2. Add generated changelog entries

    @svc-changelog
    svc-changelog committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    456f0a8 View commit details
    Browse the repository at this point in the history