You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is possible for an acceptable version of a Jakarta lib (e.g. one with a version that already uses the jakarta namespace) to erroneously be replaced if a known "bad" version also exists on the classpath.
If org:foo:1.0.0 contains a dependency on jakarta.ws.rs:jakarta.ws.rs-api:2.1.6, we incorrectly also substitute jakarta.ws.rs:jakarta.ws.rs-api:3.1.0 with javax.ws.rs:javax.ws.rs-api:2.1.1, which is likely to cause a compile failure if e.g. this project uses classes from the jakarta namespace (which is completely valid.
The text was updated successfully, but these errors were encountered:
It is possible that JakartaPackageAlignmentPlugin will call
getReplacement with an empty string for the version. Previously, this
code would erroneously return a replacement version because the
comparator for ComparableVersion returns -1 when an empty string is
compared with the maximum Jakarta version.
To address that, only look for a replacement when the version is
non-null and non-empty.
Fixes#25
It is possible for an acceptable version of a Jakarta lib (e.g. one with a version that already uses the
jakarta
namespace) to erroneously be replaced if a known "bad" version also exists on the classpath.Consider:
with a
versions.props
that reads:If
org:foo:1.0.0
contains a dependency onjakarta.ws.rs:jakarta.ws.rs-api:2.1.6
, we incorrectly also substitutejakarta.ws.rs:jakarta.ws.rs-api:3.1.0
withjavax.ws.rs:javax.ws.rs-api:2.1.1
, which is likely to cause a compile failure if e.g. this project uses classes from thejakarta
namespace (which is completely valid.The text was updated successfully, but these errors were encountered: