Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Disable certain errorprone checks for gradle plugins #504

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

dansanduleac
Copy link
Contributor

@dansanduleac dansanduleac commented Jan 15, 2019

Fixes #389

Before this PR

Gradle plugins would be subjected to certain error prone checks that are only really applicable to code that will run as part of deployed services:

  • Slf4jLogsafeArgs
  • PreferSafeLoggableExceptions

After this PR

These checks are disabled for gradle plugin projects, i.e. projects that apply java-gradle-plugin.

cc @iamdanfox

@dansanduleac dansanduleac requested a review from a team as a code owner January 15, 2019 14:20
@iamdanfox
Copy link
Contributor

👍 should hopefully allow us to get rid of the common block: https://github.com/palantir/gradle-conjure/blob/develop/gradle-conjure/build.gradle#L46-L50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants