-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically disable error-prone logging checks for gradle plugins #389
Labels
Comments
I still want this feature request |
bulldozer-bot bot
pushed a commit
that referenced
this issue
Jan 15, 2019
Fixes #389 ## Before this PR Gradle plugins would be subjected to certain error prone checks that are only really applicable to code that will run as part of deployed services: * Slf4jLogsafeArgs * PreferSafeLoggableExceptions ## After this PR These checks are disabled for gradle plugin projects, i.e. projects that apply `java-gradle-plugin`. cc @iamdanfox
Fixed by #504 |
I think we could add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened
We have lots of repos internally where we maintain gradle plugins, but the
Slf4jLogsafeArgs
andSlf4jConstantLogMessage
checks are pretty redundant as they are intended for server-side or library usage, whereas Gradle plugins are used pretty much exclusively on local machines.What should have happened
baseline-error-prone should detect when the
java-gradle-plugin
plugin has been applied and automatically disable these custom logging checks.The text was updated successfully, but these errors were encountered: