RawTypes no longer flags implicit raw types from lambdas

baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RawTypes.java

@@ -51,49 +51,53 @@ public final class RawTypes extends BugChecker
                 BugChecker.VariableTreeMatcher {
     @Override
     public Description matchVariable(VariableTree tree, VisitorState state) {
-        return testType(tree.getType());
+        return testType(tree.getType(), state);
     }
 
     @Override
     public Description matchNewClass(NewClassTree tree, VisitorState state) {
-        return testType(tree.getIdentifier());
+        return testType(tree.getIdentifier(), state);
     }
 
     @Override
     public Description matchClass(ClassTree tree, VisitorState state) {
-        Description extendsResult = testType(tree.getExtendsClause());
+        Description extendsResult = testType(tree.getExtendsClause(), state);
         if (extendsResult != Description.NO_MATCH) {
             return extendsResult;
         }
-        return testTypes(tree.getImplementsClause());
+        return testTypes(tree.getImplementsClause(), state);
     }
 
     @Override
     public Description matchMethod(MethodTree tree, VisitorState state) {
-        return testType(tree.getReturnType());
+        return testType(tree.getReturnType(), state);
     }
 
     @Override
     public Description matchTypeCast(TypeCastTree tree, VisitorState state) {
-        return testType(tree.getType());
+        return testType(tree.getType(), state);
     }
 
-    private Description testTypes(Iterable<? extends Tree> types) {
+    private Description testTypes(Iterable<? extends Tree> types, VisitorState state) {
         for (Tree type : types) {
-            Description description = testType(type);
+            Description description = testType(type, state);
             if (description != Description.NO_MATCH) {
                 return description;
             }
         }
         return Description.NO_MATCH;
     }
 
-    private Description testType(Tree type) {
+    private Description testType(Tree type, VisitorState state) {
         if (type == null) {
             return Description.NO_MATCH;
         }
         Type realType = ASTHelpers.getType(type);
         if (realType != null && realType.isRaw()) {
+            if (state.getEndPosition(type) < 0) {
+                // No source for the type node, it may be an implicit type in a lambda
+                return Description.NO_MATCH;
+            }
             return buildDescription(type)
                     .setMessage("Avoid raw types; add appropriate type parameters if possible. "
                             + "The type was: "
@@ -103,7 +107,7 @@ private Description testType(Tree type) {
                     .build();
         }
         if (type.getKind() == Tree.Kind.PARAMETERIZED_TYPE) {
-            return testTypes(((ParameterizedTypeTree) type).getTypeArguments());
+            return testTypes(((ParameterizedTypeTree) type).getTypeArguments(), state);
         }
         return Description.NO_MATCH;
     }

baseline-error-prone/src/test/java/com/palantir/baseline/errorprone/RawTypesTest.java

@@ -305,6 +305,21 @@ void testNegativeImplements3() {
                 .doTest();
     }
 
+    @Test
+    void testNegativeImplicitRawTypes() {
+        helper().addSourceLines(
+                        "Test.java",
+                        "import static org.assertj.core.api.Assertions.*;",
+                        "import java.util.function.*;",
+                        "import com.codahale.metrics.*;",
+                        "class Test {",
+                        "  void func(Metric metric) {",
+                        "    assertThat(metric).isInstanceOfSatisfying(Gauge.class, value -> {});",
+                        "  }",
+                        "}")
+                .doTest();
+    }
+
     private CompilationTestHelper helper() {
         return CompilationTestHelper.newInstance(RawTypes.class, getClass());
     }

changelog/@unreleased/pr-2119.v2.yml

@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: RawTypes no longer flags implicit raw types from lambdas
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/2119