Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Gradle CommandLineArgumentProvider are not written as lambdas #1757

Merged
merged 2 commits into from
May 6, 2021

Conversation

CRogers
Copy link
Contributor

@CRogers CRogers commented May 6, 2021

Before this PR

As seen in #1755, using a lambda with a CommandLineArgumentProvider results in the task not being cached. This is a very subtle bug similar to using lambdas for task actions.

When I was writing the code, I actually thought "can this be cached" then thought it was ok as error prone did not complain.

After this PR

==COMMIT_MSG==
Error prone check to ensure that Gradle CommandLineArgumentProviders are not written as lambdas, which causes them not to be cached.
==COMMIT_MSG==

Possible downsides?

@CRogers CRogers requested a review from carterkozak May 6, 2021 11:29
@changelog-app
Copy link

changelog-app bot commented May 6, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Error prone check to ensure that Gradle CommandLineArgumentProviders are not written as lambdas, which causes them not to be cached.

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit f35f368 into develop May 6, 2021
@bulldozer-bot bulldozer-bot bot deleted the callumr/cacheable-argument-providers branch May 6, 2021 11:35
@svc-autorelease
Copy link
Collaborator

Released 3.83.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants