Ensure that Gradle CommandLineArgumentProvider are not written as lambdas #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
approved these changes
May 6, 2021
|
Released 3.83.0 |
This was referenced Jun 22, 2021
Closed
Merged
This was referenced Sep 15, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
As seen in #1755, using a lambda with a
CommandLineArgumentProviderresults in the task not being cached. This is a very subtle bug similar to using lambdas for task actions.When I was writing the code, I actually thought "can this be cached" then thought it was ok as error prone did not complain.
After this PR
==COMMIT_MSG==
Error prone check to ensure that Gradle
CommandLineArgumentProviders are not written as lambdas, which causes them not to be cached.==COMMIT_MSG==
Possible downsides?