Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use lambda to provider compiler arguments #1755

Merged
merged 1 commit into from
May 6, 2021

Conversation

pkoenig10
Copy link
Member

#1752 broke the Immutables incremental compilation because the compile argument provider is a lambda. Because lambda class names are not stable, Gradle can't cache the results of the compile task.

Caching disabled for task ':compileJava' because:
  Non-cacheable inputs: property 'options.compilerArgumentProviders.$2' was implemented by the Java lambda 'com.palantir.baseline.plugins.BaselineImmutables$$Lambda$16803/0x0000000801da7c58'. Using Java lambdas is not supported, use an (anonymous) inner class instead.
Task ':compileJava' is not up-to-date because:
  Implementation of input property 'options.compilerArgumentProviders.$2' has changed for task ':compileJava'
The input changes require a full rebuild for incremental task ':compileJava'.
Full recompilation is required because no incremental change information is available. This is usually caused by clean builds or changing compiler arguments.

See https://docs.gradle.org/current/userguide/more_about_tasks.html#sec:how_does_it_work.

@pkoenig10
Copy link
Member Author

I've verified locally that this fixes the issue.

@bulldozer-bot bulldozer-bot bot merged commit 1a92e3e into develop May 6, 2021
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10/immutables branch May 6, 2021 01:15
@svc-autorelease
Copy link
Collaborator

Released 3.82.0

@CRogers
Copy link
Contributor

CRogers commented May 6, 2021

Oof - we definitely need to add these to the error prone check

@CRogers
Copy link
Contributor

CRogers commented May 6, 2021

Error prone to stop that happening again: #1757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants