Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AutoCloseableMustBeClosed by default #1677

Merged
merged 2 commits into from
Mar 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/@unreleased/pr-1677.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
type: improvement
improvement:
description: |-
Disable AutoCloseableMustBeClosed by default

Projects can choose to manually opt-in by enabling the `AutoCloseableMustBeClosed` check as part of their baseline configuration and running `./gradlew compileJava compileTestJava -PerrorProneApply=AutoCloseableMustBeClosed && ./gradlew format` to apply the automated fixes.
links:
- https://github.com/palantir/gradle-baseline/pull/1677
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ private static void configureErrorProneOptions(
: CheckSeverity.OFF;
}));

errorProneOptions.disable("CatchSpecificity", "UnusedVariable");
errorProneOptions.disable("AutoCloseableMustBeClosed", "CatchSpecificity", "UnusedVariable");
errorProneOptions.error(
"EqualsHashCode",
"EqualsIncompatibleType",
Expand Down