Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AutoCloseableMustBeClosed by default #1677

Merged
merged 2 commits into from
Mar 6, 2021

Conversation

schlosna
Copy link
Contributor

@schlosna schlosna commented Mar 6, 2021

Before this PR

#1673 added AutoCloseableMustBeClosed which is quite noisy on some large projects

After this PR

==COMMIT_MSG==
Disable AutoCloseableMustBeClosed by default

Projects can choose to manually opt-in by enabling the AutoCloseableMustBeClosed check as part of their baseline configuration and running ./gradlew compileJava compileTestJava -PerrorProneApply=AutoCloseableMustBeClosed && ./gradlew format to apply the automated fixes.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Mar 6, 2021

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Disable AutoCloseableMustBeClosed by default

Projects can choose to manually opt-in by enabling the AutoCloseableMustBeClosed check as part of their baseline configuration and running ./gradlew compileJava compileTestJava -PerrorProneApply=AutoCloseableMustBeClosed && ./gradlew format to apply the automated fixes.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from fawind March 6, 2021 03:46
@bulldozer-bot bulldozer-bot bot merged commit ed54545 into develop Mar 6, 2021
@bulldozer-bot bulldozer-bot bot deleted the ds/disable-AutoCloseableMustBeClosed branch March 6, 2021 03:57
@svc-autorelease
Copy link
Collaborator

Released 3.73.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants