Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Strict unused variable enforces lambda parameters (#1355)" #1357

Closed
wants to merge 2 commits into from
Closed

Revert "Strict unused variable enforces lambda parameters (#1355)" #1357

wants to merge 2 commits into from

Conversation

dansanduleac
Copy link
Contributor

This reverts commit 620c65b.

Before this PR

#1355 broke some consumers.

After this PR

==COMMIT_MSG==
Revert recent regression #1355 from 5.18.0 which broke some consumers.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented May 28, 2020 •
edited by dansanduleac
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Revert recent regression #1355 from 5.18.0 which broke some consumers.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from iamdanfox May 28, 2020 11:47
carterkozak
carterkozak approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can unrevert with a fix separately, let’s ship this to stop the bleeding.

@ferozco
Copy link
Contributor

ferozco commented May 28, 2020

👎 why rollback. lets just fix it

@dansanduleac dansanduleac deleted the ds/revert branch May 28, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak carterkozak approved these changes

@iamdanfox iamdanfox Awaiting requested review from iamdanfox

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dansanduleac @ferozco @carterkozak