Strict unused variable enforces lambda parameters #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
| boolean isPrivateMethod = methodSymbol.getModifiers().contains(Modifier.PRIVATE); | ||
| int index = methodSymbol.params.indexOf(varSymbol); | ||
| Preconditions.checkState(index != -1, "symbol must be a parameter to the owning method"); |
There was a problem hiding this comment.
might be nice to log the symbol and the method if we're gonna throw? :)
| "import java.util.function.BiFunction;", | ||
| "class Test {", | ||
| " private static BiFunction<String, String, Integer> doStuff() {", | ||
| " BiFunction<String, String, Integer> first = (String value1, String value2) -> 1;", |
There was a problem hiding this comment.
I'd maybe use one of them to check that it only renames the other one
|
👍 |
added 4 commits
May 27, 2020 15:16
…baseline into fo/unused-lambda-params
|
👍 |
|
Released 3.15.0 |
|
This just broke some code by dropping the contents before a lambda with a single (used) parameter |
dansanduleac
added a commit
that referenced
this pull request
May 28, 2020
This reverts commit 620c65b.
This was referenced May 28, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
StrictUnusedVariablewould not ensure that all lambda parameters were unusedAfter this PR
==COMMIT_MSG==
StrictUnusedVariablechecks for unused lambda parameters==COMMIT_MSG==
Possible downsides?
Some code bases may have had existing conventions for denoting unused lambda parameters. However the fix that comes along with the rule should prevent upgrades from being blocked