Change network name config as it is deprecated #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Sam-Kramer
commented
Oct 21, 2022
| @@ -2,5 +2,6 @@ version: '2' | |||
|
|
|||
| services: | |||
| webserver: | |||
| hostname: web.server.here | |||
| hostname: web | |||
There was a problem hiding this comment.
No longer can resolve the hostname when specifying the FQDN as the hostname; must specify hostname/domainname separately
|
👍 |
|
Released 1.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
network.external.nameis deprecated and as a result a warning log is emitted when runningdocker-compose ps -q, which then breaks upstream (docker-compose-rule) as commands do not filter out stderr (palantir/docker-compose-rule#720)After this PR
==COMMIT_MSG==
Use non-deprecated format for specifying an external network name
==COMMIT_MSG==
Possible downsides?