Change network name config as it is deprecated (#543)

Use non-deprecated format for specifying an external network name
palantir · Oct 24, 2022 · 47bd265 · 47bd265
1 parent eaed499
commit 47bd265
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/changelog/@unreleased/pr-543.v2.yml b/changelog/@unreleased/pr-543.v2.yml
@@ -0,0 +1,5 @@
+type: fix
+fix:
+  description: Use non-deprecated format for specifying an external network name
+  links:
+  - https://github.com/palantir/docker-proxy-rule/pull/543
diff --git a/...r-proxy-junit-jupiter/src/integrationTest/resources/DockerProxyExtensionTest-services.yml b/...r-proxy-junit-jupiter/src/integrationTest/resources/DockerProxyExtensionTest-services.yml
@@ -2,5 +2,6 @@ version: '2'
 
 services:
   webserver:
-    hostname: web.server.here
+    hostname: web
+    domainname: server.here
     image: 1science/nginx
diff --git a/docker-proxy-rule-core/src/main/resources/docker-compose.proxy.yml b/docker-proxy-rule-core/src/main/resources/docker-compose.proxy.yml
@@ -9,5 +9,5 @@ services:
 
 networks:
   default:
-    external:
-      name: {{NETWORK_NAME}}
+    external: true
+    name: {{NETWORK_NAME}}
diff --git a/docker-proxy-rule-junit4/src/integrationTest/resources/DockerProxyRuleTest-services.yml b/docker-proxy-rule-junit4/src/integrationTest/resources/DockerProxyRuleTest-services.yml
@@ -2,5 +2,6 @@ version: '2'
 
 services:
   webserver:
-    hostname: web.server.here
+    hostname: web
+    domainname: server.here
     image: 1science/nginx