Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More negative cases for set & list aliases #330

Merged
merged 3 commits into from
Mar 30, 2020
Merged

More negative cases for set & list aliases #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5dcadb
More negative cases for set & list aliases
iamdanfox Mar 30, 2020
aee6b51
Add generated changelog entries
iamdanfox Mar 30, 2020
2a1b787
autolabel
iamdanfox Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/autolabeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
'autorelease': ['master-test-cases.yml']
'merge when ready': ['*']
6 changes: 6 additions & 0 deletions changelog/@unreleased/pr-330.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: improvement
improvement:
description: Additional negative test cases ensure deserialization isn't too lenient
for list & map-like types.
links:
- https://github.com/palantir/conjure-verification/pull/330
68 changes: 57 additions & 11 deletions master-test-cases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ body:
- '{"value":null}'

# named types
# TODO(dfox): add more positive/negative cases when https://github.com/palantir/conjure/issues/193 is resolved
# TODO(dfox): add more positive/negative cases when https://github.com/palantir/conjure/issues/193 is resolved
- type: EnumExample
positive:
- '"ONE"'
Expand Down Expand Up @@ -490,97 +490,113 @@ body:
- '["abc123"]'
negative:
- 'null'
- '{}'
- type: ListBinaryAliasExample
positive:
- '[]'
- '["", "SGVsbG8sIFdvcmxk"]'
negative:
- 'null'
- '{}'
- type: ListBooleanAliasExample
positive:
- '[]'
- '[true]'
negative:
- 'null'
- '{}'
- type: ListDateTimeAliasExample
positive:
- '[]'
- '["2017-01-02T03:04:05Z"]'
negative:
- 'null'
- '{}'
- type: ListDoubleAliasExample
positive:
- '[]'
- '[10, 10.0, "NaN", "Infinity", "-Infinity"]'
negative:
- 'null'
- '{}'
- type: ListIntegerAliasExample
positive:
- '[]'
- '[0, 123]'
negative:
- 'null'
- '{}'
- type: ListRidAliasExample
positive:
- '[]'
- '["ri.service.instance.folder.foo"]'
negative:
- 'null'
- '{}'
- type: ListSafeLongAliasExample
positive:
- '[]'
- '[-9007199254740991, 0, 9007199254740991]'
negative:
- 'null'
- '{}'
- type: ListStringAliasExample
positive:
- '[]'
- '["", "hello"]'
negative:
- 'null'
- '{}'
- type: ListUuidAliasExample
positive:
- '[]'
- '["d6ddc1ac-3c1b-11e8-b467-0ed5f89f718b"]'
negative:
- 'null'
- '{}'
- type: ListAnyAliasExample
positive:
- '[]'
- '[0, "content", true, [1,2,3], {"key":3}]'
negative:
- 'null'
- '[null]'
- '{}'
- type: ListOptionalAnyAliasExample
positive:
- '[]'
- '[null, 0, "content", true, [1,2,3], {"key":3}]'
negative:
- 'null'
- '{}'
- type: SetBearerTokenAliasExample
positive:
- '[]'
- '["abc123"]'
negative:
- 'null'
- '{}'
- type: SetBinaryAliasExample
positive:
- '[]'
- '["", "SGVsbG8sIFdvcmxk"]'
negative:
- 'null'
- '{}'
- type: SetBooleanAliasExample
positive:
- '[]'
- '[true]'
negative:
- 'null'
- '{}'
- type: SetDateTimeAliasExample
positive:
- '[]'
- '["2017-01-02T03:04:05Z"]'
negative:
- 'null'
- '{}'
- type: SetDoubleAliasExample
positive:
- '[]'
Expand All @@ -589,69 +605,85 @@ body:
# - '[+0, -0]'
negative:
- 'null'
- '{}'
- type: SetIntegerAliasExample
positive:
- '[]'
- '[0, 123]'
negative:
- 'null'
- '{}'
- type: SetRidAliasExample
positive:
- '[]'
- '["ri.service.instance.folder.foo"]'
negative:
- 'null'
- '{}'
- type: SetSafeLongAliasExample
positive:
- '[]'
- '[-9007199254740991, 0, 9007199254740991]'
negative:
- 'null'
- '{}'
- type: SetStringAliasExample
positive:
- '[]'
- '["", "hello"]'
negative:
- 'null'
- '{}'
- type: SetUuidAliasExample
positive:
- '[]'
- '["d6ddc1ac-3c1b-11e8-b467-0ed5f89f718b"]'
negative:
- 'null'
- '{}'
- type: SetAnyAliasExample
positive:
- '[]'
- '[0, "content", true, [1,2,3], {"key":3}]'
negative:
- 'null'
- '[null]'
- '{}'
- type: SetOptionalAnyAliasExample
positive:
- '[]'
- '[null, 0, "content", true, [1,2,3], {"key":3}]'
negative:
- 'null'
- '{}'
- type: MapBearerTokenAliasExample
positive:
- '{}'
- '{"abc123": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapBinaryAliasExample
positive:
- '{}'
- '{"SGVsbG8sIFdvcmxk": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapBooleanAliasExample
positive:
- '{}'
- '{"true": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapDateTimeAliasExample
positive:
- '{}'
- '{"2017-01-02T03:04:05Z": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapDoubleAliasExample
positive:
- '{}'
Expand All @@ -664,43 +696,57 @@ body:
- '{"-Infinity": true}'
- '{"10": true, "3e2": true}'
negative:
- 'null'
- '[]'
- '{"10": true, "10e0": false}'
- '{"10": true, "10.0": false}'
- type: MapIntegerAliasExample
positive:
- '{}'
- '{"0": true}'
- '{"123": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapRidAliasExample
positive:
- '{}'
- '{"ri.service.instance.folder.foo": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapSafeLongAliasExample
positive:
- '{}'
- '{"-9007199254740991": true}'
- '{"0": true}'
- '{"9007199254740991": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapStringAliasExample
positive:
- '{}'
- '{"": true}'
- '{"hello": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapUuidAliasExample
positive:
- '{}'
- '{"d6ddc1ac-3c1b-11e8-b467-0ed5f89f718b": true}'
negative: []
negative:
- 'null'
- '[]'
- type: MapEnumExampleAlias
positive:
- '{"ONE": "", "TWO": ""}'
- '{"ONE": "", "TWO": "", "UNKNOWN_VARIANT": ""}'
# https://github.com/palantir/conjure/issues/193
# negative:
negative:
- 'null'
- '[]'
# - '{"ONE": "", "TWO": "", "INVALID CHARS": ""}'
singleHeaderParam:
- type: bearertoken
Expand Down