Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More negative cases for set & list aliases #330

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

iamdanfox
Copy link
Contributor

Before this PR

I'm making sure dialogue deserializes empty container types correctly, but my initial implementation was not very strict, so it would happily turn HTTP 204 with body {} into an empty list (which seems confusing/wrong).

After this PR

==COMMIT_MSG==
Additional negative test cases ensure deserialization isn't too lenient for list & map-like types.
==COMMIT_MSG==

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Mar 30, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Additional negative test cases ensure deserialization isn't too lenient for list & map-like types.

Check the box to generate changelog(s)

  • Generate changelog entry

@policy-bot policy-bot bot requested a review from fawind March 30, 2020 16:46
@iamdanfox
Copy link
Contributor Author

🦠

@bulldozer-bot bulldozer-bot bot merged commit c45462c into develop Mar 30, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/more-negative-cases branch March 30, 2020 17:30
@svc-autorelease
Copy link
Collaborator

Released 0.18.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants