Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing functionality that conditionally provides Node.js #56

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Removing functionality that conditionally provides Node.js #56

merged 1 commit into from
Dec 6, 2023

Conversation

pacostas
Copy link
Contributor

Summary

This PR removes the functionality that provides Node.js and npm conditionally. Similar to what node-engine buildpack does, ubi-nodejs-extension on this PR will always provides Node.js and npm

Use Cases

  • No matter the folder structure of the app, it will provide Node.js and npm.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner November 30, 2023 09:09
@pacostas pacostas mentioned this pull request Nov 30, 2023
Merged
5 tasks
@pacostas pacostas changed the title Removing functionality that conditionally providing Node.js Removing functionality that conditionally provides Node.js Nov 30, 2023
mhdawson
mhdawson approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TisVictress TisVictress added the semver:minor A change requiring a minor version bump label Dec 6, 2023
@TisVictress TisVictress merged commit 37b870b into paketo-buildpacks:main Dec 6, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacostas @mhdawson @TisVictress