Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ubi buildpackless builder integration #274

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Adding ubi buildpackless builder integration #274

merged 4 commits into from
Jan 19, 2024

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Nov 29, 2023 •
edited
Loading

Merge After

Summary

This PR, tests node-run-script against ubi buildpackless base builder in conjuction with ubi nodejs extention .

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas force-pushed the adding-ubi-buildpackless-builder-integration branch 2 times, most recently from 34724ed to 9faebad Compare November 30, 2023 09:14
@pacostas pacostas marked this pull request as ready for review November 30, 2023 09:15
@pacostas pacostas requested a review from a team as a code owner November 30, 2023 09:15
mhdawson
mhdawson approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas
Adding ubi-buildpackless-builder and ubi-nodejs-extension on integrat…
16bc004 
…ion tests

adding ubi-buildpackless-builder on project path integration tests

adding ubi-buildpackless-builder on simple npm integration tests

adding ubi-buildpackless-builder on simple yarn integration tests

adding enabling experimental feature

adding ubi-buildpackless-build on vue_npm and vue_yarn integration tests
@pacostas pacostas force-pushed the adding-ubi-buildpackless-builder-integration branch from 9faebad to 16bc004 Compare December 4, 2023 13:56
@pacostas
Copy link
Contributor Author

pacostas commented Jan 5, 2024

@TisVictress For some reason the if statement had been committed wrongly, fixed it on this commit 399f318

Also the ubi-nodejs-extension is failing, as the latest changes are not included on the latest release which is requirement for the tests to pass. I opened an issue for cutting a new release paketo-buildpacks/ubi-nodejs-extension#71

@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label Jan 19, 2024
@thitch97 thitch97 merged commit 3d062f0 into paketo-buildpacks:main Jan 19, 2024
11 of 12 checks passed
@pacostas pacostas deleted the adding-ubi-buildpackless-builder-integration branch January 22, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thitch97 thitch97 thitch97 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@TisVictress TisVictress Awaiting requested review from TisVictress TisVictress is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacostas @thitch97 @mhdawson