Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add semver generator example #680

Merged
merged 2 commits into from
Oct 14, 2024
Merged

chore: Add semver generator example #680

merged 2 commits into from
Oct 14, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Oct 10, 2024

Depends on #678

@coveralls
Copy link

coveralls commented Oct 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11319318326

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.402%
Totals Coverage Status
Change from base Build 11319304311: 0.0%
Covered Lines: 2465
Relevant Lines: 2557
💛 - Coveralls

JP-Ellis
JP-Ellis approved these changes Oct 13, 2024
View reviewed changes
Copy link

@JP-Ellis JP-Ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very big PR 😅

At a high level, this looks fine so I'll approve, but I can't say I've done a deep dive into the changes.

@tienvx
Copy link
Contributor Author

tienvx commented Oct 14, 2024

I merged master into this branch. Now this PR is a lot smaller.

@tienvx tienvx merged commit db10175 into pact-foundation:master Oct 14, 2024
18 checks passed
@tienvx tienvx deleted the add-semver-generator-example branch October 14, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis