Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support generators in more matchers #678

Merged

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Oct 10, 2024

Support generators for these matchers:

  • notEmpty
  • equality (not sure how useful it is)
  • type

This feature is for preparing adding another feature: supporting fromProviderState syntax in matching expression. e.g.

matching(equalTo, fromProviderState('${Auth}', 'AST00004'))

Depends on #677

@tienvx tienvx force-pushed the support-generators-in-more-matchers branch from 9d61cd9 to 6161391 Compare October 10, 2024 00:54
@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11319222280

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 96.375%

Totals Coverage Status
Change from base Build 11319211440: 0.004%
Covered Lines: 2446
Relevant Lines: 2538

💛 - Coveralls

@tienvx tienvx force-pushed the support-generators-in-more-matchers branch from 6161391 to 9f20a8e Compare October 10, 2024 01:00
@tienvx tienvx changed the title Support generators in more matchers feat: Support generators in more matchers Oct 10, 2024
@tienvx tienvx merged commit efda9d4 into pact-foundation:master Oct 14, 2024
18 checks passed
@tienvx tienvx deleted the support-generators-in-more-matchers branch October 14, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants