Pin the dependencies of the Rust code gen tools #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous commit, only the version of `protoc-gen-prost/tonic` was pinned. However, Cargo would still ignore the lock file and use the latest version of dependencies for `protoc-gen-prost/tonic`. This meant that any new release of dependencies (such as `prost-build`) could result in differences in the generated code. This commit addresses the issue by adding `--locked` to the `cargo install` command, ensuring Cargo respects the lock file when installing code generation tools. The Rust code has been regenerated using this updated configuration. Signed-off-by: Campbell He <kp.campbell.he@duskmoon314.com>
|
There are 206 additions and 56 deletions. Changes in rust code are caused by the version of |
chrispsommers
approved these changes
Sep 24, 2024
|
It worked, thanks again @duskmoon314 for fixing this so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous commit, only the version of
protoc-gen-prost/tonicwas pinned. However, Cargo would still ignore the lock file and use the latest version of dependencies forprotoc-gen-prost/tonic. This meant that any new release of dependencies (such asprost-build) could result in differences in the generated code.This commit addresses the issue by adding
--lockedto thecargo installcommand, ensuring Cargo respects the lock file when installing code generation tools.The Rust code has been regenerated using this updated configuration.