Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 491 - update changelog for 1.4.0 changes #501

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

chrispsommers
Copy link
Collaborator

Reviewed all commits since v1.3.0 and ensured every change was mentioned in the change log. Added some structure to categorize the changes.

Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: chris <chris.sommers@keysight.com>
Signed-off-by: chris <chris.sommers@keysight.com>
@chrispsommers chrispsommers marked this pull request as ready for review September 16, 2024 22:19
@chrispsommers
Copy link
Collaborator Author

@jafingerhut @smolkaj could you please take a look? I'm hoping to pave the way for a release before the 4 Workshop.

Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks!

@chrispsommers chrispsommers merged commit f304ae3 into p4lang:main Sep 24, 2024
5 checks passed
@chrispsommers
Copy link
Collaborator Author

chrispsommers commented Sep 24, 2024

@duskmoon314 For some reason, merging in this modest change to .mdk and .md files produced a codecheck failure in the rust generated code. DO you have any idea why this might have happened? Here's the failed job: https://github.com/p4lang/p4runtime/actions/runs/11004409981/job/30555272186

I experimentally ran codegen/update.sh in my workspace on the source branch and there were no changes to generated Rust code so I'm curious what would "fix" this breakage?

@duskmoon314
Copy link
Contributor

Weirdly, running CI/check_codegen.sh on the latest commit doesn't fail in my local environment. I need more time to find out why.

@chrispsommers
Copy link
Collaborator Author

Thanks for responding so quickly and offering to investigate!

@duskmoon314
Copy link
Contributor

I think I found out why.

In the previous PR #500, I only pinned the protoc-gen-prost/tonic version. But Cargo ignores the lock file by default. Thus, when building the docker image, cargo install will always use the latest version of protoc-gen-prost/tonic's dependencies.

Three days ago, prost released a new version. This version changed some generation methods, which is why the CI failed.

I tried adding --locked to cargo install, which seems to solve this problem. A new PR will be opened soon.

@duskmoon314
Copy link
Contributor

#502 is opened to solve the issue. Please review.

I hope this is the last commit to solve this kind version issue. orz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants