[P4Testgen] Move common code of BMv2 test back ends into a common class. #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy-g
force-pushed
the
testbackend-common-code
branch
from
462c6d2
to
b253d2c
Compare
fruffy-g
changed the title
fruffy-g
force-pushed
the
testbackend-common-code
branch
2 times, most recently
from
ca584fc
to
b643901
Compare
fruffy-g
force-pushed
the
testbackend-common-code
branch
from
b643901
to
1c568d6
Compare
jonathan-dilorenzo
requested changes
Nov 6, 2023
backends/p4tools/modules/testgen/targets/bmv2/test/BMV2ProtobufXfail.cmake
Show resolved
Hide resolved
backends/p4tools/modules/testgen/targets/bmv2/test_backend/common.cpp
Outdated
Show resolved
Hide resolved
jonathan-dilorenzo
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR of a series of three to refactor the BMv2 test back ends.
This PR moves code that is common to the increasing amount of test back ends into a
commonclass. This makes it easier to add new test back ends to the BMv2 P4Testgen extension.It also renables the BMv2 Protobuf back end and updates its Xfails.