Update some XFails.

p4lang · Nov 6, 2023 · 1c568d6 · 1c568d6
1 parent 7b1aabb
commit 1c568d6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/backends/p4tools/modules/testgen/targets/bmv2/test/BMV2ProtobufXfail.cmake b/backends/p4tools/modules/testgen/targets/bmv2/test/BMV2ProtobufXfail.cmake
@@ -9,6 +9,13 @@
 ####################################################################################################
 # These are failures in P4Testgen that need to be fixed.
 
+p4tools_add_xfail_reason(
+  "testgen-p4c-bmv2-protobuf"
+  "Non-numeric, non-boolean member expression: .* Type: Type_Stack"
+  # We can not expand stacks in parsers because information about .next is lost.
+  # P4Testgen needs to maintain its own internal .next variable for stacks.
+  array-copy-bmv2.p4
+)
 
 p4tools_add_xfail_reason(
   "testgen-p4c-bmv2-protobuf"
@@ -117,6 +124,13 @@ p4tools_add_xfail_reason(
   issue1304.p4
 )
 
+p4tools_add_xfail_reason(
+  "testgen-p4c-bmv2-protobuf"
+  "is not a constant"
+  # Using an uninitialized variable as a header stack index in the parser.
+  parser-unroll-test10.p4
+)
+
 ####################################################################################################
 # 4. PARAMETERS NEEDED
 ####################################################################################################

diff --git a/backends/p4tools/modules/testgen/targets/bmv2/test/BMV2STFXfail.cmake b/backends/p4tools/modules/testgen/targets/bmv2/test/BMV2STFXfail.cmake
@@ -8,14 +8,6 @@
 # These issues needed to be tracked and fixed in P4C.
 ####################################################################################################
 
-p4tools_add_xfail_reason(
-  "testgen-p4c-bmv2-stf"
-  "Non-numeric, non-boolean member expression: .* Type: Type_Stack"
-  # We can not expand stacks in parsers because information about .next is lost.
-  # P4Testgen needs to maintain its own internal .next variable for stacks.
-  array-copy-bmv2.p4
-)
-
 p4tools_add_xfail_reason(
   "testgen-p4c-bmv2-stf"
   "simple_switch died with return code -6"
@@ -75,6 +67,14 @@ p4tools_add_xfail_reason(
 # These are failures in P4Testgen that need to be fixed.
 ####################################################################################################
 
+p4tools_add_xfail_reason(
+  "testgen-p4c-bmv2-stf"
+  "Non-numeric, non-boolean member expression: .* Type: Type_Stack"
+  # We can not expand stacks in parsers because information about .next is lost.
+  # P4Testgen needs to maintain its own internal .next variable for stacks.
+  array-copy-bmv2.p4
+)
+
 p4tools_add_xfail_reason(
   "testgen-p4c-bmv2-stf"
   "Cast failed"