Create a new state for initializations #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafingerhut
reviewed
Apr 15, 2020
| } | ||
| state L3_i { | ||
| b.extract<I>(hdr.i); | ||
| transition L3_start; |
There was a problem hiding this comment.
I might be missing something, but this file issue2314-frontend.p4 seems to be showing the same bug that exists without this change: state L3_i transitions to L3_start, which makes an assignment to l3_etherType that should only be done when the sub parser is first called. Should this transition be to L3_start_0 instead, perhaps?
jafingerhut
reviewed
Apr 16, 2020
frontends/p4/moveDeclarations.h
Outdated
| @@ -67,17 +67,20 @@ class MoveDeclarations : public Transform { | |||
|
|
|||
| /** After MoveDeclarations, some variable declarations in the "local" | |||
| * section of a parser and control may still have initializers; these are moved | |||
| * into the start state, and to the beginning of the apply body repectively. | |||
| * into the a new start state, and to the beginning of the apply body repectively. | |||
There was a problem hiding this comment.
minor typo: s/into the a new start state/into a new start state/
jafingerhut
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2314