make all external IPs in header copyable #2170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think we could stand to keep the IP as a link. It doesn't really cost us anything if the copy button is also there. |
|
re-linked: |
| > | ||
| {eip.ip} | ||
| </a> | ||
| <CopyToClipboard text={eip.ip} /> |
There was a problem hiding this comment.
I think this needs an ml-1 to do what the gap-1 was doing when this was at top level. I was afraid it would then look too close to the slash on the right, but it seems fine to me.
before
after
david-crespo
approved these changes
Apr 19, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 23, 2024
oxidecomputer/console@c008d36...d2a9345 * [d2a9345f](oxidecomputer/console@d2a9345f) oxidecomputer/console#2142 * [2b6d0f7b](oxidecomputer/console@2b6d0f7b) oxidecomputer/console#2185 * [e649e7b7](oxidecomputer/console@e649e7b7) oxidecomputer/console#2170 * [0f4bed01](oxidecomputer/console@0f4bed01) oxidecomputer/console#2180 * [06f4b868](oxidecomputer/console@06f4b868) oxidecomputer/console#2167 * [a25e84e8](oxidecomputer/console@a25e84e8) oxidecomputer/console#2166 * [629c94a6](oxidecomputer/console@629c94a6) oxidecomputer/console#2168
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 23, 2024
oxidecomputer/console@c008d36...d2a9345 * [d2a9345f](oxidecomputer/console@d2a9345f) oxidecomputer/console#2142 * [2b6d0f7b](oxidecomputer/console@2b6d0f7b) oxidecomputer/console#2185 * [e649e7b7](oxidecomputer/console@e649e7b7) oxidecomputer/console#2170 * [0f4bed01](oxidecomputer/console@0f4bed01) oxidecomputer/console#2180 * [06f4b868](oxidecomputer/console@06f4b868) oxidecomputer/console#2167 * [a25e84e8](oxidecomputer/console@a25e84e8) oxidecomputer/console#2166 * [629c94a6](oxidecomputer/console@629c94a6) oxidecomputer/console#2168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2171
We currently only allow for a "copy to clipboard" function when there's a single external IP in the list in the header. This PR makes it so that any IP in the list is copyable.
We should add a dropdown, a la ListPlusCell, for when there are more than … 3(? 2?) IPs, but that can be a subsequent PR.