-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plus icon to all "new" buttons above tables #2168
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Nice. I think I lean against putting the plus on promote image. I'm surprised that every other one is a create action! I thought there would be more weird ones around. Since it really is a create button I'd make the name less generic to reflect that, maybe simply There might be a couple other buttons here and there that need the plus, like |
Can we go for We could probably make icons for the non-create. Not exactly sure what promote would be, but for consistency I think it's worth doing. |
oxidecomputer/console@c008d36...d2a9345 * [d2a9345f](oxidecomputer/console@d2a9345f) oxidecomputer/console#2142 * [2b6d0f7b](oxidecomputer/console@2b6d0f7b) oxidecomputer/console#2185 * [e649e7b7](oxidecomputer/console@e649e7b7) oxidecomputer/console#2170 * [0f4bed01](oxidecomputer/console@0f4bed01) oxidecomputer/console#2180 * [06f4b868](oxidecomputer/console@06f4b868) oxidecomputer/console#2167 * [a25e84e8](oxidecomputer/console@a25e84e8) oxidecomputer/console#2166 * [629c94a6](oxidecomputer/console@629c94a6) oxidecomputer/console#2168
oxidecomputer/console@c008d36...d2a9345 * [d2a9345f](oxidecomputer/console@d2a9345f) oxidecomputer/console#2142 * [2b6d0f7b](oxidecomputer/console@2b6d0f7b) oxidecomputer/console#2185 * [e649e7b7](oxidecomputer/console@e649e7b7) oxidecomputer/console#2170 * [0f4bed01](oxidecomputer/console@0f4bed01) oxidecomputer/console#2180 * [06f4b868](oxidecomputer/console@06f4b868) oxidecomputer/console#2167 * [a25e84e8](oxidecomputer/console@a25e84e8) oxidecomputer/console#2166 * [629c94a6](oxidecomputer/console@629c94a6) oxidecomputer/console#2168
This PR updates the buttons (and links, where appropriate) that sit just above tables in the UI, adding a plus icon (technically, a roundel) to the buttons.
![Screenshot 2024-04-18 at 10 04 39 PM](https://private-user-images.githubusercontent.com/22547/323837558-ae212aee-216d-4384-a84c-ea2a84281ece.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzE2ODMsIm5iZiI6MTczOTkzMTM4MywicGF0aCI6Ii8yMjU0Ny8zMjM4Mzc1NTgtYWUyMTJhZWUtMjE2ZC00Mzg0LWE4NGMtZWEyYTg0MjgxZWNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE5VDAyMTYyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA3YjYyMTJiOGI4MjZiNDgyZWI2ZWU0ODcyOGE2MDJkODI0YTdiZGU4OTllMjU0ZjIzMDQyZjVjNWIyNTkwNjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.89wMe5uBpKk5Tjjs1YaJiXwQva75IQFamDG4OUyx1XA)
I'm not totally sure that the icon makes sense when paired with the text reading "Promote image", but figured that consistency across the buttons was more important than the semantic quibbling on that one button. That being said, I'm open to input.