Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plus icon to all "new" buttons above tables #2168

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

charliepark
Copy link
Contributor

This PR updates the buttons (and links, where appropriate) that sit just above tables in the UI, adding a plus icon (technically, a roundel) to the buttons.
Screenshot 2024-04-18 at 10 04 39 PM

Screenshot 2024-04-18 at 10 11 00 PM

I'm not totally sure that the icon makes sense when paired with the text reading "Promote image", but figured that consistency across the buttons was more important than the semantic quibbling on that one button. That being said, I'm open to input.

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Apr 19, 2024 3:20pm

@david-crespo
Copy link
Collaborator

Nice. I think I lean against putting the plus on promote image. I'm surprised that every other one is a create action! I thought there would be more weird ones around. Since it really is a create button I'd make the name less generic to reflect that, maybe simply CreateButton and CreateLink.

There might be a couple other buttons here and there that need the plus, like Add SSH key on instance create. On the other hand it feels weird to put it on create and attach disk buttons, so maybe it's better to stay away from that entirely on the form.

@david-crespo
Copy link
Collaborator

Looking great. Last thing: what about these? I feel like all the options are weird. If it's on create only, why is it not on attach? If it's on both, it looks kind of weird and busy. Maybe neither is the least attention-grabbing.

image

@benjaminleonard
Copy link
Contributor

benjaminleonard commented Apr 19, 2024

Can we go for text-accent-secondary on these icons. Otherwise I think they end up a little too weighty compared to the text.

We could probably make icons for the non-create. Not exactly sure what promote would be, but for consistency I think it's worth doing.

@david-crespo
Copy link
Collaborator

Better.

image

@david-crespo david-crespo enabled auto-merge (squash) April 19, 2024 15:20
@david-crespo david-crespo merged commit 629c94a into main Apr 19, 2024
8 checks passed
@david-crespo david-crespo deleted the plus-icon-on-table-button branch April 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants