Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): react-perf/no-new-object-as-props #2044

Closed
Tracked by #2041
DonIsaac opened this issue Jan 15, 2024 · 0 comments
Closed
Tracked by #2041

feat(linter): react-perf/no-new-object-as-props #2044

DonIsaac opened this issue Jan 15, 2024 · 0 comments
Labels
A-linter Area - Linter C-enhancement Category - New feature or request E-Help Wanted Experience level - For the experienced collaborators

Comments

@DonIsaac
Copy link
Contributor

DonIsaac commented Jan 15, 2024 •
edited
Loading

Note: the original rule bans object literals in JSX expressions declared at the top-level scope. Since this doesn't have any performance problems (it only ever renders once, since it's not in the component's rendering logic), we should consider allowing this case.
@DonIsaac DonIsaac mentioned this issue Jan 15, 2024
Closed
@DonIsaac DonIsaac added C-enhancement Category - New feature or request E-Help Wanted Experience level - For the experienced collaborators A-linter Area - Linter labels Jan 15, 2024
@camc314 camc314 mentioned this issue Jan 21, 2024
Merged
@Boshen Boshen closed this as completed in 5ca07bc Jan 22, 2024
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@byteHulk @IWANABETHATGUY
feat(linter): eslint-plugin-react-perf (oxc-project#2086)
0a50a7a 
Relates oxc-project#2041 

Closes oxc-project#2042
Closes oxc-project#2043
Closes oxc-project#2044
Closes oxc-project#2045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linter Area - Linter C-enhancement Category - New feature or request E-Help Wanted Experience level - For the experienced collaborators
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DonIsaac