Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ eslint-plugin-react-perf #2041

Closed
DonIsaac opened this issue Jan 15, 2024 · 2 comments · Fixed by #2119
Closed

☂️ eslint-plugin-react-perf #2041

DonIsaac opened this issue Jan 15, 2024 · 2 comments · Fixed by #2119
Labels
A-linter Area - Linter C-enhancement Category - New feature or request E-Help Wanted Experience level - For the experienced collaborators

Comments

@DonIsaac
Copy link
Contributor

DonIsaac commented Jan 15, 2024 •
edited by github-actions bot
Loading

Warning

This comment is maintained by CI. Do not edit this comment directly.
To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is tracking issue for eslint-plugin-react-perf.

There are 4(+ 0 deprecated) rules.

  • 0/3 recommended rules are remaining as TODO
    • All done! 🎉
  • 0/1 not recommended rules are remaining as TODO
    • All done! 🎉

To get started, run the following command:

just new-react-perf-rule <RULE_NAME>

Then register the rule in crates/oxc_linter/src/rules.rs and also declare_all_lint_rules at the bottom.

Recommended rules

✨: 3, 🚫: 0 / total: 3
Status Name Docs
✨ react-perf/jsx-no-new-object-as-prop
✨ react-perf/jsx-no-new-array-as-prop
✨ react-perf/jsx-no-new-function-as-prop

✨ = Implemented, 🚫 = No need to implement

Not recommended rules

✨: 1, 🚫: 0 / total: 1
Status Name Docs
✨ react-perf/jsx-no-jsx-as-prop

✨ = Implemented, 🚫 = No need to implement
@DonIsaac DonIsaac added C-enhancement Category - New feature or request E-Help Wanted Experience level - For the experienced collaborators A-linter Area - Linter labels Jan 15, 2024
@DonIsaac DonIsaac mentioned this issue Jan 15, 2024
Open
@byteHulk byteHulk mentioned this issue Jan 19, 2024
Merged
Boshen pushed a commit that referenced this issue Jan 22, 2024
@byteHulk
feat(linter): eslint-plugin-react-perf (#2086)
5ca07bc 
Relates #2041 

Closes #2042
Closes #2043
Closes #2044
Closes #2045
@Boshen
Copy link
Member

Boshen commented Jan 22, 2024

Last task:

  • add a cli flag --react-perf-plugin and change all the rules to correctness.

@byteHulk byteHulk mentioned this issue Jan 22, 2024
Merged
Boshen pushed a commit that referenced this issue Jan 22, 2024
@byteHulk
feat: introduce --react-perf-plugin CLI flag, update rules to correct…
20a34b5 
…ness (#2119)

#2041 (comment)

Closes #2041
@Boshen Boshen changed the title ☂️ Linter: eslint-plugin-react-perf ☂️ eslint-plugin-react-perf Jan 26, 2024
@daniilium
Copy link

How do these rules for Visual Studio Code extensions work? I'm using the oxlintrc.json configuration file.

IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@byteHulk @IWANABETHATGUY
feat(linter): eslint-plugin-react-perf (oxc-project#2086)
0a50a7a 
Relates oxc-project#2041 

Closes oxc-project#2042
Closes oxc-project#2043
Closes oxc-project#2044
Closes oxc-project#2045
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this issue May 29, 2024
@byteHulk @IWANABETHATGUY
feat: introduce --react-perf-plugin CLI flag, update rules to correct…
da8ca91 
…ness (oxc-project#2119)

oxc-project#2041 (comment)

Closes oxc-project#2041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linter Area - Linter C-enhancement Category - New feature or request E-Help Wanted Experience level - For the experienced collaborators
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce --react-perf-plugin CLI flag, update rules to correctness byteHulk/oxc
3 participants
@Boshen @DonIsaac @daniilium