Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Bump commit ids for tests #5652

Merged
merged 2 commits into from
Aug 12, 2021
Merged

[tests-only][full-ci] Bump commit ids for tests #5652

merged 2 commits into from
Aug 12, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Aug 10, 2021

Description

Bump core and oCIS commit ids for tests

Related Issue

owncloud/QA#684

How Has This Been Tested?

  • CI

@saw-jan saw-jan self-assigned this Aug 10, 2021
@saw-jan saw-jan mentioned this pull request Aug 10, 2021
Closed
4 tasks
This was referenced Aug 10, 2021
Merged
Merged
@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/18137/42/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oC10SharingFolderAdvPermissionsGrp https://drone.owncloud.com/owncloud/web/18140/20/1
The following scenarios passed on retry:

  • webUISharingFolderAdvancedPermissionsGroups/shareAdvancePermissionsGroup.feature:69

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18145/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:27

@ownclouders
Copy link
Contributor

Results for oC10MoveUpload https://drone.owncloud.com/owncloud/web/18145/14/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:90

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18145/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@saw-jan saw-jan force-pushed the bump-commit-ids branch 3 times, most recently from 5d67d88 to c64cbda Compare August 11, 2021 03:14
@phil-davis
Copy link
Contributor

phil-davis commented Aug 11, 2021 •
edited
Loading

Note: issue #5656 "[QA] webUIUpload/upload.feature:90 failing randomly" - one of the developers noticed this last night. It looks like it is failing a lot. It will be good to make it more reliable. Hopefully there is some "easy" test code timing fix.

https://drone.owncloud.com/owncloud/web/18156/14/14

https://drone.owncloud.com/owncloud/web/18156/43/14

@saw-jan saw-jan force-pushed the bump-commit-ids branch 2 times, most recently from 4d4a384 to b1d1dad Compare August 11, 2021 06:13
@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/18167/42/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oC10iPhone2 https://drone.owncloud.com/owncloud/web/18169/46/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:90

@saw-jan saw-jan force-pushed the bump-commit-ids branch 2 times, most recently from 3b5347a to 9dfb133 Compare August 11, 2021 08:30
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18173/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18173/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

@saw-jan saw-jan force-pushed the bump-commit-ids branch 3 times, most recently from 44e0173 to 8b7d0a0 Compare August 11, 2021 10:12
@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/18179/3/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:99

@saw-jan
Copy link
Member Author

saw-jan commented Aug 11, 2021 •
edited
Loading

Test webUIUpload/upload.feature:99 is failing due to overwrite step not being successful as file is Locked

SEVERE - http://owncloud/remote.php/webdav/lorem.txt - Failed to load resource: the server responded with a status of 423 (Locked)

@saw-jan saw-jan force-pushed the bump-commit-ids branch 4 times, most recently from ac56d2b to 7b84300 Compare August 11, 2021 12:11
@saw-jan saw-jan force-pushed the bump-commit-ids branch 4 times, most recently from 7e1e8d9 to d825216 Compare August 12, 2021 03:51
saw-jan
saw-jan commented Aug 12, 2021
View reviewed changes
tests/acceptance/stepDefinitions/generalContext.js
Comment on lines -154 to +156
const assertContentOfLocalFileIs = function(fullPathOfLocalFile, expectedContent) {
const actualContent = fs.readFileSync(fullPathOfLocalFile, { encoding: 'utf-8' })
return client.assert.strictEqual(
const assertContentOfLocalFileIs = function(fullPathOfLocalFile, actualContent) {
const expectedContent = fs.readFileSync(fullPathOfLocalFile, { encoding: 'utf-8' })
return assert.strictEqual(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using node assert instead of nightwatchjs

saw-jan
saw-jan commented Aug 12, 2021
View reviewed changes
tests/acceptance/features/webUIUpload/upload.feature
@@ -86,7 +86,7 @@ Feature: File Upload
And file "new-lorem.txt" should be listed on the webUI
And as "Alice" the content of "simple-folder/new-lorem.txt" should be the same as the content of local file "new-lorem.txt"

@smokeTest
@smokeTest @disablePreviews
Copy link
Member Author

@saw-jan saw-jan Aug 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5652 (comment)
adding @disablePreviews makes the test pass. It seems that @disablePreviews tag reduces locking issue

@saw-jan saw-jan mentioned this pull request Aug 12, 2021
Closed
@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18200/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18200/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/web/18200/14/14

runsh: Total unexpected failed scenarios throughout the test run:
webUIUpload/upload.feature:152

"Scenario: upload overwriting a file into a public share"

Maybe that scenario also needs @disablePreviews

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18202/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@phil-davis phil-davis marked this pull request as ready for review August 12, 2021 06:11
@phil-davis phil-davis merged commit d6afce7 into master Aug 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-ids branch August 12, 2021 06:11
@phil-davis phil-davis mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @ownclouders @phil-davis